No sandbox on flaky GPU tests
Adds the --no-sandbox flag to the following tests on Win10 x64 Debug
(NVIDIA):
1. info_collection_tests
2. depth_capture_tests
3. gpu_process_launch_tests
4. context_lost_tests
This will hopefully give us more information about why the renderer
process is flakily crashing/hanging without producing any minidumps.
Also drive-by removes a --no-sandbox addition to another GPU test on the
same bot which is no longer necessary.
[email protected]
Bug: 1007013
Change-Id: I9bbcc7a48e6eee61eccd8fb9f4bb40fa5e7954f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050146
Reviewed-by: Brian Sheedy <[email protected]>
Commit-Queue: Brian Sheedy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#740506}
diff --git a/testing/buildbot/chromium.gpu.json b/testing/buildbot/chromium.gpu.json
index 7159c2a2..dfc6a2f8 100644
--- a/testing/buildbot/chromium.gpu.json
+++ b/testing/buildbot/chromium.gpu.json
@@ -3990,7 +3990,7 @@
"--browser=debug_x64",
"--passthrough",
"-v",
- "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc"
+ "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --no-sandbox"
],
"isolate_name": "telemetry_gpu_integration_test",
"merge": {
@@ -4019,7 +4019,7 @@
"--browser=debug_x64",
"--passthrough",
"-v",
- "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc"
+ "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --no-sandbox"
],
"isolate_name": "telemetry_gpu_integration_test",
"merge": {
@@ -4048,7 +4048,7 @@
"--browser=debug_x64",
"--passthrough",
"-v",
- "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc"
+ "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --no-sandbox"
],
"isolate_name": "telemetry_gpu_integration_test",
"merge": {
@@ -4106,7 +4106,7 @@
"--browser=debug_x64",
"--passthrough",
"-v",
- "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --force_high_performance_gpu",
+ "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --force_high_performance_gpu --no-sandbox",
"--expected-vendor-id",
"10de",
"--expected-device-id",
diff --git a/testing/buildbot/chromium.win.json b/testing/buildbot/chromium.win.json
index b0d400e..f509adc 100644
--- a/testing/buildbot/chromium.win.json
+++ b/testing/buildbot/chromium.win.json
@@ -3749,8 +3749,7 @@
},
{
"args": [
- "--disable-features=WebRTC-H264WithOpenH264FFmpeg",
- "--no-sandbox"
+ "--disable-features=WebRTC-H264WithOpenH264FFmpeg"
],
"experiment_percentage": 100,
"merge": {
diff --git a/testing/buildbot/test_suite_exceptions.pyl b/testing/buildbot/test_suite_exceptions.pyl
index 6aa20ad..94db838b 100644
--- a/testing/buildbot/test_suite_exceptions.pyl
+++ b/testing/buildbot/test_suite_exceptions.pyl
@@ -438,9 +438,6 @@
# crbug.com/868082
'args': [
'--disable-features=WebRTC-H264WithOpenH264FFmpeg',
- # TODO(https://crbug.com/1007013): Remove this flag when it's no
- # longer necessary to figure out why the renderer process is crashing.
- '--no-sandbox',
],
},
'Win10 Tests x64 Code Coverage': {
@@ -540,6 +537,13 @@
'--is-asan',
]
},
+ 'Win10 x64 Debug (NVIDIA)': {
+ 'args': [
+ # TODO(https://crbug.com/1007013): Remove this flag when it's no
+ # longer necessary to figure out why the renderer process is hanging.
+ '--extra-browser-args=--no-sandbox',
+ ],
+ },
},
},
'crashpad_tests': {
@@ -579,6 +583,15 @@
'remove_from': [
'Android FYI Release (Pixel 2)',
],
+ 'modifications': {
+ 'Win10 x64 Debug (NVIDIA)': {
+ 'args': [
+ # TODO(https://crbug.com/1007013): Remove this flag when it's no
+ # longer necessary to figure out why the renderer process is hanging.
+ '--extra-browser-args=--no-sandbox',
+ ],
+ },
+ },
},
'extensions_browsertests': {
'remove_from': [
@@ -729,6 +742,15 @@
'remove_from': [
'Android FYI Release (Pixel 2)',
],
+ 'modifications': {
+ 'Win10 x64 Debug (NVIDIA)': {
+ 'args': [
+ # TODO(https://crbug.com/1007013): Remove this flag when it's no
+ # longer necessary to figure out why the renderer process is hanging.
+ '--extra-browser-args=--no-sandbox',
+ ],
+ },
+ },
},
'hardware_accelerated_feature_tests': {
# TODO(https://crbug.com/850107): Remove the Android FYI Release (Pixel 2)
@@ -753,6 +775,15 @@
'Mac V8 FYI Release (Intel)',
'Win V8 FYI Release (NVIDIA)',
],
+ 'modifications': {
+ 'Win10 x64 Debug (NVIDIA)': {
+ 'args': [
+ # TODO(https://crbug.com/1007013): Remove this flag when it's no
+ # longer necessary to figure out why the renderer process is hanging.
+ '--extra-browser-args=--no-sandbox',
+ ],
+ },
+ },
},
'interactive_ui_tests': {
'remove_from': [
