[DownloadBubble] Remove IPH promo for download toolbar button
This removes the IPH (primarily added in crrev.com/c/4348484), that
directed users to manage their downloads in the new download bubble.
This is no longer needed now that the download bubble has been
launched for several milestones, and it is getting in the way of
manual testing for other IPH promos displayed from the download
toolbar button.
This CL removes:
* Feature and configs associated with the IPH.
* Strings and translation screenshots used in the IPH.
* The profile pref that used to indicate whether it should be shown.
* Hooks in DownloadBubbleUIController to log the trigger condition.
* Tests referring to the IPH behavior.
Bug: 1420750
Change-Id: I314baa6b5cdd6f9ff2ac75e2dc47938af42c1050
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5171062
Reviewed-by: Rushan Suleymanov <[email protected]>
Commit-Queue: Lily Chen <[email protected]>
Reviewed-by: Xinghui Lu <[email protected]>
Reviewed-by: Dana Fried <[email protected]>
Reviewed-by: Daniel Rubery <[email protected]>
Reviewed-by: Gabriel Charette <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1244702}
diff --git a/chrome/browser/prefs/browser_prefs.cc b/chrome/browser/prefs/browser_prefs.cc
index e406d936..7a6e93f 100644
--- a/chrome/browser/prefs/browser_prefs.cc
+++ b/chrome/browser/prefs/browser_prefs.cc
@@ -952,6 +952,9 @@
const char kSyncedLastTimePasswordCheckCompleted[] =
"profile.credentials_last_password_checkup_time";
+// Deprecated 01/2024.
+const char kDownloadBubbleIphSuppression[] = "suppress_download_bubble_iph";
+
// Register local state used only for migration (clearing or moving to a new
// key).
void RegisterLocalStatePrefsForMigration(PrefRegistrySimple* registry) {
@@ -1338,6 +1341,9 @@
// Deprecated 01/2024.
registry->RegisterTimePref(kSyncedLastTimePasswordCheckCompleted,
base::Time());
+
+ // Deprecated 01/2024.
+ registry->RegisterBooleanPref(kDownloadBubbleIphSuppression, false);
}
void ClearSyncRequestedPrefAndMaybeMigrate(PrefService* profile_prefs) {
@@ -2561,6 +2567,9 @@
// Added 01/2024.
profile_prefs->ClearPref(kSyncedLastTimePasswordCheckCompleted);
+ // Added 01/2024.
+ profile_prefs->ClearPref(kDownloadBubbleIphSuppression);
+
// Please don't delete the following line. It is used by PRESUBMIT.py.
// END_MIGRATE_OBSOLETE_PROFILE_PREFS
