Google Git
Sign in
chromium / chromium / src.git / 680972d7f662ac2414aaa8fa73f66cacf9e88c9b
commit680972d7f662ac2414aaa8fa73f66cacf9e88c9b[log] [tgz]
authorVadym Doroshenko <[email protected]>Thu Mar 01 17:31:40 2018
committerCommit Bot <[email protected]>Thu Mar 01 17:31:40 2018
tree268aab1b39b4c38b08971bce5f98d64d26430516
parent0753a97df25d497e872e2945848907ca9a6661bf [diff]
[IOS Password Manager] Async suggestions retrieval.

When a password form is added dynamically (i.e. with JavaScript after finishing of a page load)
IOS Password Manager may learn about existing of this form only after user clicking on
some field in this form. On CL https://chromium-review.googlesource.com/c/chromium/src/+/601969
it was implemented retrieving credentials from the Password Store as soon as the user clicked
on dynamically added form and then credentials are autofilled. But fill on account select is not
available until the user makes another interaction with the form (for example start typing of
username). That's suboptimal user experience, it would be good to propose fill on
account select immediately as soon as the user clicks the first time in the form.

This CL implements async suggestion response to Autofill framework in the same way as it's
already implemented in Autofill:
1.When checkIfSuggestionsAvailableForForm (password_controller.mm) is called, and it's
found that credentials haven't been retrieved yet for this page, the callback is saved
untile response from the Password Store is received.
2.It's implemented that Password Store response is propagated to PasswordController even if case
when there are no credentials saved for this page in order to inform Autofill framework that
no suggestions are available.

Bug: 708597, 709011, 708634
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Idecc3e621100f3e1b0a3803ce944c4cc116fc3a4
Reviewed-on: https://chromium-review.googlesource.com/921961
Commit-Queue: Vadym Doroshenko <[email protected]>
Reviewed-by: Vasilii Sukhanov <[email protected]>
Cr-Commit-Position: refs/heads/master@{#540200}
7 files changed
tree: 268aab1b39b4c38b08971bce5f98d64d26430516
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_cleaner/
  11. chrome_elf/
  12. chromecast/
  13. chromeos/
  14. cloud_print/
  15. components/
  16. content/
  17. courgette/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. mash/
  33. media/
  34. mojo/
  35. native_client_sdk/
  36. net/
  37. notification_helper/
  38. pdf/
  39. ppapi/
  40. printing/
  41. remoting/
  42. rlz/
  43. sandbox/
  44. services/
  45. skia/
  46. sql/
  47. storage/
  48. styleguide/
  49. testing/
  50. third_party/
  51. tools/
  52. ui/
  53. url/
  54. .clang-format
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. AUTHORS
  62. BUILD.gn
  63. CODE_OF_CONDUCT.md
  64. codereview.settings
  65. DEPS
  66. ENG_REVIEW_OWNERS
  67. LICENSE
  68. LICENSE.chromium_os
  69. OWNERS
  70. PRESUBMIT.py
  71. PRESUBMIT_test.py
  72. PRESUBMIT_test_mocks.py
  73. README.md
  74. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .