Remove first interaction time bucket prefs from welcome tour.
These prefs were added as part of an effort to backfill easier to grok
time metrics for the welcome tour experiment. Due to a change in team
capacity, the planned metrics will no longer be backfilled so as to
simplify the solution.
Bug: b:313703523
Change-Id: I95bd0f05d959a3a8f7c77db28f95f16902bddd2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5278777
Reviewed-by: Dominic Battre <[email protected]>
Reviewed-by: Andrew Xu <[email protected]>
Commit-Queue: David Black <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1259323}
diff --git a/chrome/browser/prefs/browser_prefs.cc b/chrome/browser/prefs/browser_prefs.cc
index 8e10086..7f72246 100644
--- a/chrome/browser/prefs/browser_prefs.cc
+++ b/chrome/browser/prefs/browser_prefs.cc
@@ -4,6 +4,7 @@
#include "chrome/browser/prefs/browser_prefs.h"
+#include <array>
#include <optional>
#include <string>
#include <string_view>
@@ -979,6 +980,19 @@
constexpr char kScreenTimeEnabled[] = "policy.screen_time";
#endif
+// Deprecated 02/2024.
+#if BUILDFLAG(IS_CHROMEOS_ASH)
+constexpr std::array<const char*, 6u>
+ kWelcomeTourTimeBucketsOfFirstInteractions = {
+ "ash.welcome_tour.interaction_time.ExploreApp.first_time_bucket",
+ "ash.welcome_tour.interaction_time.FilesApp.first_time_bucket",
+ "ash.welcome_tour.interaction_time.Launcher.first_time_bucket",
+ "ash.welcome_tour.interaction_time.QuickSettings.first_time_bucket",
+ "ash.welcome_tour.interaction_time.Search.first_time_bucket",
+ "ash.welcome_tour.interaction_time.SettingsApp.first_time_bucket",
+};
+#endif
+
// Register local state used only for migration (clearing or moving to a new
// key).
void RegisterLocalStatePrefsForMigration(PrefRegistrySimple* registry) {
@@ -1374,6 +1388,13 @@
#endif
registry->RegisterBooleanPref(kSafeBrowsingDeepScanPromptSeen, false);
registry->RegisterTimePref(kSafeBrowsingEsbEnabledTimestamp, base::Time());
+
+// Deprecated 02/2024.
+#if BUILDFLAG(IS_CHROMEOS_ASH)
+ for (const char* pref : kWelcomeTourTimeBucketsOfFirstInteractions) {
+ registry->RegisterIntegerPref(pref, -1);
+ }
+#endif
}
void ClearSyncRequestedPrefAndMaybeMigrate(PrefService* profile_prefs) {
@@ -2620,6 +2641,13 @@
profile_prefs->ClearPref(kSafeBrowsingDeepScanPromptSeen);
profile_prefs->ClearPref(kSafeBrowsingEsbEnabledTimestamp);
+ // Deprecated 02/2024.
+#if BUILDFLAG(IS_CHROMEOS_ASH)
+ for (const char* pref : kWelcomeTourTimeBucketsOfFirstInteractions) {
+ profile_prefs->ClearPref(pref);
+ }
+#endif
+
// Please don't delete the following line. It is used by PRESUBMIT.py.
// END_MIGRATE_OBSOLETE_PROFILE_PREFS
