[Code Health] Remove expired Power.* histograms
Remove the following 3 expired histograms:
Power.IdleScreenOffCountDaily
Power.IdleSuspendCountDaily
Power.LidClosedSuspendCountDaily
After removing these 3 histograms, some PowerMetricsReporter methods
becomes no-op and PowerMetricsReporterTest is no longer needed. This
CL also cleans up the unit tests and the no-op functions.
Bug: 1447166
Change-Id: I0295da23913aa5f23a696aaf8534e89bb03a599e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4676663
Reviewed-by: Gabriel Charette <[email protected]>
Reviewed-by: Jesse Doherty <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Code-Coverage: Findit <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1171864}
diff --git a/chrome/browser/prefs/browser_prefs.cc b/chrome/browser/prefs/browser_prefs.cc
index 4962661e..444f47a8 100644
--- a/chrome/browser/prefs/browser_prefs.cc
+++ b/chrome/browser/prefs/browser_prefs.cc
@@ -928,6 +928,15 @@
const char kPasswordsGroupingInfoRequested[] =
"password_manager.passwords_grouping_info_requested";
+// Deprecated 07/2023.
+#if BUILDFLAG(IS_CHROMEOS_ASH)
+const char kPowerMetricsIdleScreenOffCount[] =
+ "power.metrics.idle_screen_off_count";
+const char kPowerMetricsIdleSuspendCount[] = "power.metrics.idle_suspend_count";
+const char kPowerMetricsLidClosedSuspendCount[] =
+ "power.metrics.lid_closed_suspend_count";
+#endif // BUILDFLAG(IS_CHROMEOS_ASH)
+
// Register local state used only for migration (clearing or moving to a new
// key).
void RegisterLocalStatePrefsForMigration(PrefRegistrySimple* registry) {
@@ -1339,6 +1348,13 @@
// Deprecated 07/2023
registry->RegisterBooleanPref(kPasswordsGroupingInfoRequested, false);
+
+// Deprecated 07/2023.
+#if BUILDFLAG(IS_CHROMEOS_ASH)
+ registry->RegisterIntegerPref(kPowerMetricsIdleScreenOffCount, 0);
+ registry->RegisterIntegerPref(kPowerMetricsIdleSuspendCount, 0);
+ registry->RegisterIntegerPref(kPowerMetricsLidClosedSuspendCount, 0);
+#endif // BUILDFLAG(IS_CHROMEOS_ASH)
}
} // namespace
@@ -2492,6 +2508,13 @@
// Added 07/2023.
profile_prefs->ClearPref(kPasswordsGroupingInfoRequested);
+ // Added 07/2023.
+#if BUILDFLAG(IS_CHROMEOS_ASH)
+ profile_prefs->ClearPref(kPowerMetricsIdleScreenOffCount);
+ profile_prefs->ClearPref(kPowerMetricsIdleSuspendCount);
+ profile_prefs->ClearPref(kPowerMetricsLidClosedSuspendCount);
+#endif
+
// Please don't delete the following line. It is used by PRESUBMIT.py.
// END_MIGRATE_OBSOLETE_PROFILE_PREFS
