Remove expired flags: enable-desktop-pwas and enable-experimental-app-banners
This CL removes two flags:
- enable-desktop-pwas: This is on by default for desktop.
- enable-experimental-app-banners: This is on by default for Android
These flags are being removed together because
AppBannerManager::IsExperimentalAppBannersEnabled() was true if either
one was true. This was in effect true for all platforms by default.
TBR: [email protected]
Bug: 959086
Change-Id: I0c9f170f3be7ba1cacc7750c9268316912c98ff4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609744
Commit-Queue: Alan Cutter <[email protected]>
Reviewed-by: Ben Wells <[email protected]>
Reviewed-by: Evan Stade <[email protected]>
Reviewed-by: Azeem Arshad <[email protected]>
Reviewed-by: Adrienne Porter Felt <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#662060}
diff --git a/chrome/browser/prefs/browser_prefs.cc b/chrome/browser/prefs/browser_prefs.cc
index 9379053..0a97bacf 100644
--- a/chrome/browser/prefs/browser_prefs.cc
+++ b/chrome/browser/prefs/browser_prefs.cc
@@ -152,7 +152,6 @@
#include "chrome/browser/extensions/api/cryptotoken_private/cryptotoken_private_api.h"
#include "chrome/browser/extensions/api/tabs/tabs_api.h"
#include "chrome/browser/extensions/extension_web_ui.h"
-#include "chrome/browser/extensions/launch_util.h"
#include "chrome/browser/extensions/ntp_overridden_bubble_delegate.h"
#include "chrome/browser/ui/toolbar/toolbar_actions_bar.h"
#include "chrome/browser/ui/webui/extensions/extensions_ui.h"
@@ -453,6 +452,10 @@
const char kSignInPromoShowNTPBubble[] = "sync_promo.show_ntp_bubble";
#endif // !defined(OS_ANDROID)
+// Deprecated 5/2019
+const char kBookmarkAppCreationLaunchType[] =
+ "extensions.bookmark_app_creation_launch_type";
+
// Register prefs used only for migration (clearing or moving to a new key).
void RegisterProfilePrefsForMigration(
user_prefs::PrefRegistrySyncable* registry) {
@@ -514,6 +517,8 @@
registry->RegisterBooleanPref(kSignInPromoShowOnFirstRunAllowed, true);
registry->RegisterBooleanPref(kSignInPromoShowNTPBubble, false);
#endif // !defined(OS_ANDROID)
+
+ registry->RegisterIntegerPref(kBookmarkAppCreationLaunchType, 0);
}
} // namespace
@@ -744,7 +749,6 @@
extensions::AudioAPI::RegisterUserPrefs(registry);
extensions::ExtensionPrefs::RegisterProfilePrefs(registry);
extensions::ExtensionsUI::RegisterProfilePrefs(registry);
- extensions::launch_util::RegisterProfilePrefs(registry);
extensions::NtpOverriddenBubbleDelegate::RegisterPrefs(registry);
extensions::RuntimeAPI::RegisterPrefs(registry);
update_client::RegisterProfilePrefs(registry);
@@ -1107,4 +1111,7 @@
profile_prefs->ClearPref(kSignInPromoShowOnFirstRunAllowed);
profile_prefs->ClearPref(kSignInPromoShowNTPBubble);
#endif // !defined(OS_ANDROID)
+
+ // Added 5/2019.
+ profile_prefs->ClearPref(kBookmarkAppCreationLaunchType);
}
