Files TS: Convert the dlp_enterprise_connectors.js to TS
Bug: b:319189127
Change-Id: Ib6e01e2bb6bd7678375daccca5c8fd3f192f4993
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5296829
Auto-Submit: Luciano Pacheco <[email protected]>
Reviewed-by: Ben Reich <[email protected]>
Commit-Queue: Ben Reich <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1260977}
diff --git a/ui/file_manager/integration_tests/BUILD.gn b/ui/file_manager/integration_tests/BUILD.gn
index 60f11089..047ee4c 100644
--- a/ui/file_manager/integration_tests/BUILD.gn
+++ b/ui/file_manager/integration_tests/BUILD.gn
@@ -11,7 +11,6 @@
"test_util.ts",
# File Manager.
- "file_manager/dlp_enterprise_connectors.js",
"file_manager/search.js",
"file_manager/transfer.js",
]
@@ -42,7 +41,7 @@
"file_manager/dlp.ts",
- # "file_manager/dlp_enterprise_connectors.ts",
+ "file_manager/dlp_enterprise_connectors.ts",
"file_manager/drive_specific.ts",
"file_manager/file_dialog.ts",
diff --git a/ui/file_manager/integration_tests/file_manager/dlp_enterprise_connectors.js b/ui/file_manager/integration_tests/file_manager/dlp_enterprise_connectors.ts
similarity index 90%
rename from ui/file_manager/integration_tests/file_manager/dlp_enterprise_connectors.js
rename to ui/file_manager/integration_tests/file_manager/dlp_enterprise_connectors.ts
index a992fee..be7aa7a 100644
--- a/ui/file_manager/integration_tests/file_manager/dlp_enterprise_connectors.js
+++ b/ui/file_manager/integration_tests/file_manager/dlp_enterprise_connectors.ts
@@ -3,7 +3,6 @@
// found in the LICENSE file.
import {addEntries, EntryType, RootPath, sendTestMessage, TestEntryInfo} from '../test_util.js';
-import {testcase} from '../testcase.js';
import {remoteCall, setupAndWaitUntilReady} from './background.js';
import {DirectoryTreePageObject} from './page_objects/directory_tree.js';
@@ -54,9 +53,7 @@
// Tests that proceeding two warnings, the first is triggered by DLP and the
// second is triggered by Enterprise Connectors, will move all the copied files.
-// @ts-ignore: error TS4111: Property 'twoWarningsProceeded' comes from an index
-// signature, so it must be accessed with ['twoWarningsProceeded'].
-testcase.twoWarningsProceeded = async () => {
+export async function twoWarningsProceeded() {
// Add entry to Downloads.
await addEntries(['local'], [allowedFileEntry, warnedFileEntry]);
@@ -111,9 +108,7 @@
await remoteCall.focus(appId, ['#file-list:not([hidden])']);
// Select all files.
- const ctrlA = ['#file-list', 'a', true, false, false];
- // @ts-ignore: error TS2556: A spread argument must either have a tuple type
- // or be passed to a rest parameter.
+ const ctrlA = ['#file-list', 'a', true, false, false] as const;
await remoteCall.fakeKeyDown(appId, ...ctrlA);
// Check: the file-list should be selected.
await remoteCall.waitForElement(appId, '#file-list li[selected]');
@@ -168,14 +163,12 @@
await remoteCall.waitForFiles(
appId,
[allowedFileEntry.getExpectedRow(), warnedFileEntry.getExpectedRow()]);
-};
+}
// Tests that blocking different files by DLP and Enterprise Connectors will
// copy all the file except the blocked ones. A block panel will be shown in the
// end with the blocked files count.
-// @ts-ignore: error TS4111: Property 'differentBlockPolicies' comes from an
-// index signature, so it must be accessed with ['differentBlockPolicies'].
-testcase.differentBlockPolicies = async () => {
+export async function differentBlockPolicies() {
// Add entry to Downloads.
await addEntries(
['local'], [allowedFileEntry, blockedFileEntry1, blockedFileEntry2]);
@@ -224,9 +217,7 @@
await remoteCall.focus(appId, ['#file-list:not([hidden])']);
// Select all files.
- const ctrlA = ['#file-list', 'a', true, false, false];
- // @ts-ignore: error TS2556: A spread argument must either have a tuple type
- // or be passed to a rest parameter.
+ const ctrlA = ['#file-list', 'a', true, false, false] as const;
await remoteCall.fakeKeyDown(appId, ...ctrlA);
// Check: the file-list should be selected.
await remoteCall.waitForElement(appId, '#file-list li[selected]');
@@ -257,4 +248,4 @@
await remoteCall.waitForFiles(
appId,
[allowedFileEntry.getExpectedRow(), blockedFileEntry1.getExpectedRow()]);
-};
+}
diff --git a/ui/file_manager/integration_tests/testcase.ts b/ui/file_manager/integration_tests/testcase.ts
index 2843eee..6a0f6ff 100644
--- a/ui/file_manager/integration_tests/testcase.ts
+++ b/ui/file_manager/integration_tests/testcase.ts
@@ -12,7 +12,7 @@
import * as directoryTreeTests from './file_manager/directory_tree.js';
import * as directoryTreeContextMenuTests from './file_manager/directory_tree_context_menu.js';
import * as dlpTests from './file_manager/dlp.js';
-// import * as dlpEnterpriseConnectorsTests from './file_manager/dlp_enterprise_connectors.js';
+import * as dlpEnterpriseConnectorsTests from './file_manager/dlp_enterprise_connectors.js';
import * as driveSpecificTests from './file_manager/drive_specific.js';
import * as fileDialogTests from './file_manager/file_dialog.js';
import * as fileDisplayTests from './file_manager/file_display.js';
@@ -70,7 +70,7 @@
...directoryTreeTests,
...directoryTreeContextMenuTests,
...dlpTests,
- // ...dlpEnterpriseConnectorsTests,
+ ...dlpEnterpriseConnectorsTests,
...driveSpecificTests,
...fileDialogTests,
...fileDisplayTests,
