Update docs for finding engineering contacts.
Add a new page which is an updated copy of
https://www.chromium.org/developers/finding-somebody-who-knows-how-a-piece-of-code-works/
(The old doc should be deleted/redirected to this new doc.)
Also add some cross-linking in other relevant docs.
Bug: none
Change-Id: I821c9e9b53def500e450628328bd271ee9db6815
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6405935
Reviewed-by: Rick Byers <[email protected]>
Reviewed-by: Sam Fortiner <[email protected]>
Commit-Queue: Evan Stade <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1440333}
diff --git a/docs/cl_tips.md b/docs/cl_tips.md
index a3ba549..cebc42e 100644
--- a/docs/cl_tips.md
+++ b/docs/cl_tips.md
@@ -73,7 +73,12 @@
complexity to the codebase. The codebase is inherently mutable and additional
abstractions can be added _if and when_ they are needed.
-## Optimize for reducing timezone latency
+## Choosing the right reviewers
+
+For more on identifying the best contact, see
+[finding somebody who knows how a piece of code works](finding_reviewer.md).
+
+### Optimize for reducing timezone latency
The Chromium project has contributors from around the world, and it is very
likely that you will not be in the same timezone as a reviewer. You should
@@ -82,14 +87,14 @@
[minimizing lag across
timezones](https://www.chromium.org/developers/contributing-code/minimizing-review-lag-across-time-zones/).
-## Get a full review from a single, main reviewer, before asking many OWNERs
+### Get a full review from a single, main reviewer, before asking many OWNERs
If your CL requires the approval from 3+ OWNERs, get a small number of main
reviewers (most commonly 1) to review the entire CL so that OWNERs don’t need to
deal with issues that anybody can detect. This is particularly useful if OWNERs
are in a different timezone.
-## Depend on more-specific owners
+### Depend on more-specific owners
Wherever possible, choose reviewers from the deepest OWNERS files adjacent to
the most significant aspects of your change. Once their review is complete, add
