Update obsolete_system
As discussed, don't gate update checking on "end of the line" status.
Our update servers can handle the load, and even if we don't want to
show the user the option to update, we should take an update if
available.
Also, switch to a namespace as per the style guide
(https://google.github.io/styleguide/cppguide.html#Nonmember,_Static_Member,_and_Global_Functions)
"Do not use a class simply to group static members."
Bug: 1405325
Change-Id: I76c099ec51b9d2d4e3675c173571aff2dc995093
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4195097
Reviewed-by: Mark Mentovai <[email protected]>
Commit-Queue: Mark Mentovai <[email protected]>
Auto-Submit: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1097085}
diff --git a/chrome/browser/obsolete_system/obsolete_system_linux.cc b/chrome/browser/obsolete_system/obsolete_system_linux.cc
index 902f910..5953872e 100644
--- a/chrome/browser/obsolete_system/obsolete_system_linux.cc
+++ b/chrome/browser/obsolete_system/obsolete_system_linux.cc
@@ -19,27 +19,28 @@
"Fedora 30", "Fedora 31", "openSUSE Leap 15.0", "openSUSE Leap 15.1",
};
-// static
-bool ObsoleteSystem::IsObsoleteNowOrSoon() {
+namespace ObsoleteSystem {
+
+bool IsObsoleteNowOrSoon() {
auto distro = base::GetLinuxDistro();
for (const char* obsolete : kObsoleteDistros) {
- if (base::StartsWith(distro, obsolete))
+ if (base::StartsWith(distro, obsolete)) {
return true;
+ }
}
return false;
}
-// static
-std::u16string ObsoleteSystem::LocalizedObsoleteString() {
+std::u16string LocalizedObsoleteString() {
return l10n_util::GetStringUTF16(IDS_LINUX_OBSOLETE);
}
-// static
-bool ObsoleteSystem::IsEndOfTheLine() {
+bool IsEndOfTheLine() {
return false;
}
-// static
-const char* ObsoleteSystem::GetLinkURL() {
+const char* GetLinkURL() {
return kLinuxObsoleteUrl;
}
+
+} // namespace ObsoleteSystem
