| commit | c527daa2a32f652c195959563725d47d47237501 | [log] [tgz] |
|---|---|---|
| author | Victor Hugo Vianna Silva <[email protected]> | Tue Jul 02 01:35:44 2024 |
| committer | Chromium LUCI CQ <[email protected]> | Tue Jul 02 01:35:44 2024 |
| tree | 4862f4a21733037d822d40d0d510e63bf8aebc88 | |
| parent | 716d2f129e6590c9fc4e4968b27c10587369a2b6 [diff] [blame] |
[fixit] Remove TestSyncService::SetTransportState() Test-only change. This CL removes SetTransportState() - which sets the transport state arbitrarily, possibly in an inconsistent manner - and instead exposes SetMaxTransportState(). This will be the value of GetTransportState() when there is no auth error (TransportState::PAUSED) nor disable reason (TransportState::DISABLED). Fixed: 348605115 Change-Id: I6b2995704eb816150b1237a7aff6d72c7a8fb207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5665303 Reviewed-by: Steven Holte <[email protected]> Reviewed-by: Marc Treib <[email protected]> Reviewed-by: Matthew Jones <[email protected]> Commit-Queue: Victor Vianna <[email protected]> Code-Coverage: [email protected] <[email protected]> Cr-Commit-Position: refs/heads/main@{#1321957}
diff --git a/chrome/browser/sharing/sharing_utils_unittest.cc b/chrome/browser/sharing/sharing_utils_unittest.cc index e99914ac..248be63 100644 --- a/chrome/browser/sharing/sharing_utils_unittest.cc +++ b/chrome/browser/sharing/sharing_utils_unittest.cc
@@ -86,7 +86,7 @@ } TEST_F(SharingUtilsTest, SyncDisabled_Configuring) { - test_sync_service_.SetTransportState( + test_sync_service_.SetMaxTransportState( syncer::SyncService::TransportState::CONFIGURING); test_sync_service_.GetUserSettings()->SetSelectedTypes( /*sync_everything=*/false,