Remove using directives ("using namespace x") in chrome/browser/sharing/.
Bug: 82078
Change-Id: Iebfc438ca750766748023d2ea2acfc59c3fb2803
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842960
Auto-Submit: Peter Kasting <[email protected]>
Commit-Queue: Richard Knoll <[email protected]>
Reviewed-by: Richard Knoll <[email protected]>
Cr-Commit-Position: refs/heads/master@{#703261}
diff --git a/chrome/browser/sharing/ack_message_handler_unittest.cc b/chrome/browser/sharing/ack_message_handler_unittest.cc
index 2681295..6addf3d 100644
--- a/chrome/browser/sharing/ack_message_handler_unittest.cc
+++ b/chrome/browser/sharing/ack_message_handler_unittest.cc
@@ -7,26 +7,21 @@
#include "chrome/browser/sharing/proto/sharing_message.pb.h"
#include "testing/gtest/include/gtest/gtest.h"
-using SharingMessage = chrome_browser_sharing::SharingMessage;
-using namespace testing;
-
namespace {
-const char kTestMessageId[] = "test_message_id";
-
class TestObserver : public AckMessageHandler::AckMessageObserver {
public:
void OnAckReceived(const std::string& message_id) override {
received_message_id_ = message_id;
}
- const std::string& received_message_id() { return received_message_id_; }
+ std::string received_message_id() const { return received_message_id_; }
private:
std::string received_message_id_;
};
-class AckMessageHandlerTest : public Test {
+class AckMessageHandlerTest : public testing::Test {
protected:
AckMessageHandlerTest() { ack_message_handler_.AddObserver(&test_observer_); }
@@ -37,7 +32,9 @@
} // namespace
TEST_F(AckMessageHandlerTest, OnMessage) {
- SharingMessage sharing_message;
+ constexpr char kTestMessageId[] = "test_message_id";
+
+ chrome_browser_sharing::SharingMessage sharing_message;
sharing_message.mutable_ack_message()->set_original_message_id(
kTestMessageId);