Remove Breaking News feature
The NTP Breaking News feature is no longer in use. Remove feature and
clean up dead code.
Change-Id: Ia57235abb93c78406e9ce3a56c2c0290e947dfa0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562897
Reviewed-by: Gauthier Ambard <[email protected]>
Reviewed-by: Gabriel Charette <[email protected]>
Reviewed-by: Nicolas Ouellet-Payeur <[email protected]>
Reviewed-by: Steven Holte <[email protected]>
Reviewed-by: Patrick Noland <[email protected]>
Commit-Queue: Natalie Chouinard <[email protected]>
Cr-Commit-Position: refs/heads/master@{#651414}diff --git a/chrome/browser/prefs/browser_prefs.cc b/chrome/browser/prefs/browser_prefs.cc
index 5a184580..5e52095 100644
--- a/chrome/browser/prefs/browser_prefs.cc
+++ b/chrome/browser/prefs/browser_prefs.cc
@@ -206,8 +206,6 @@
#include "chrome/browser/media/android/cdm/media_drm_origin_id_manager.h"
#include "components/cdm/browser/media_drm_storage_impl.h"
#include "components/feed/buildflags.h"
-#include "components/ntp_snippets/breaking_news/breaking_news_gcm_app_handler.h"
-#include "components/ntp_snippets/breaking_news/subscription_manager_impl.h"
#include "components/ntp_snippets/category_rankers/click_based_category_ranker.h"
#include "components/ntp_tiles/popular_sites_impl.h"
#if BUILDFLAG(ENABLE_FEED_IN_CHROME)
@@ -421,7 +419,19 @@
"ntp_suggestions.downloads.assets.dismissed_ids";
const char kDismissedOfflinePageDownloadSuggestions[] =
"ntp_suggestions.downloads.offline_pages.dismissed_ids";
-#endif
+
+// Deprecated 4/2019.
+const char kBreakingNewsSubscriptionDataToken[] =
+ "ntp_suggestions.breaking_news_subscription_data.token";
+const char kBreakingNewsSubscriptionDataIsAuthenticated[] =
+ "ntp_suggestions.breaking_news_subscription_data.is_authenticated";
+const char kBreakingNewsGCMSubscriptionTokenCache[] =
+ "ntp_suggestions.breaking_news_gcm_subscription_token_cache";
+const char kBreakingNewsGCMLastTokenValidationTime[] =
+ "ntp_suggestions.breaking_news_gcm_last_token_validation_time";
+const char kBreakingNewsGCMLastForcedSubscriptionTime[] =
+ "ntp_suggestions.breaking_news_gcm_last_forced_subscription_time";
+#endif // defined(OS_ANDROID)
// Register prefs used only for migration (clearing or moving to a new key).
void RegisterProfilePrefsForMigration(
@@ -463,7 +473,16 @@
#if defined(OS_ANDROID)
registry->RegisterListPref(kDismissedAssetDownloadSuggestions);
registry->RegisterListPref(kDismissedOfflinePageDownloadSuggestions);
-#endif
+
+ registry->RegisterStringPref(kBreakingNewsSubscriptionDataToken,
+ std::string());
+ registry->RegisterBooleanPref(kBreakingNewsSubscriptionDataIsAuthenticated,
+ false);
+ registry->RegisterStringPref(kBreakingNewsGCMSubscriptionTokenCache,
+ std::string());
+ registry->RegisterInt64Pref(kBreakingNewsGCMLastTokenValidationTime, 0);
+ registry->RegisterInt64Pref(kBreakingNewsGCMLastForcedSubscriptionTime, 0);
+#endif // defined(OS_ANDROID)
}
} // namespace
@@ -754,9 +773,7 @@
registry);
ContentSuggestionsNotifierService::RegisterProfilePrefs(registry);
explore_sites::HistoryStatisticsReporter::RegisterPrefs(registry);
- ntp_snippets::BreakingNewsGCMAppHandler::RegisterProfilePrefs(registry);
ntp_snippets::ClickBasedCategoryRanker::RegisterProfilePrefs(registry);
- ntp_snippets::SubscriptionManagerImpl::RegisterProfilePrefs(registry);
OomInterventionDecider::RegisterProfilePrefs(registry);
#endif // defined(OS_ANDROID)
@@ -1021,6 +1038,13 @@
// Added 4/2019.
profile_prefs->ClearPref(kDismissedAssetDownloadSuggestions);
profile_prefs->ClearPref(kDismissedOfflinePageDownloadSuggestions);
+
+ // Added 4/2019.
+ profile_prefs->ClearPref(kBreakingNewsSubscriptionDataToken);
+ profile_prefs->ClearPref(kBreakingNewsSubscriptionDataIsAuthenticated);
+ profile_prefs->ClearPref(kBreakingNewsGCMSubscriptionTokenCache);
+ profile_prefs->ClearPref(kBreakingNewsGCMLastTokenValidationTime);
+ profile_prefs->ClearPref(kBreakingNewsGCMLastForcedSubscriptionTime);
#endif // defined(OS_ANDROID)
#if defined(OS_CHROMEOS)
