[Permissions] Clean profile pref
This CL aimed to deprecate un-used prefs kQuietNotificationPermissionPromoWasShown and kQuietNotificationPermissionShouldShowPromo which used to use for quiet notification education promo.
Bug: 379632777
Change-Id: I21d4f5328448d146f1f9c646368062929687262f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6016665
Reviewed-by: Dana Fried <[email protected]>
Commit-Queue: Yifan Luo <[email protected]>
Reviewed-by: Elias Klim <[email protected]>
Reviewed-by: Gabriel Charette <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1387851}
diff --git a/chrome/browser/prefs/browser_prefs.cc b/chrome/browser/prefs/browser_prefs.cc
index 040070c..f00c9f9 100644
--- a/chrome/browser/prefs/browser_prefs.cc
+++ b/chrome/browser/prefs/browser_prefs.cc
@@ -1159,6 +1159,14 @@
"discount_consent_show_interest_in";
#endif // !BUILDFLAG(IS_ANDROID)
+// Deprecated 11/2024
+constexpr char kQuietNotificationPermissionPromoWasShown[] =
+ "profile.content_settings.quiet_permission_ui_promo.was_shown."
+ "notifications";
+constexpr char kQuietNotificationPermissionShouldShowPromo[] =
+ "profile.content_settings.quiet_permission_ui_promo.should_show."
+ "notifications";
+
// Register local state used only for migration (clearing or moving to a new
// key).
void RegisterLocalStatePrefsForMigration(PrefRegistrySimple* registry) {
@@ -1641,6 +1649,12 @@
// Deprecated 11/2024
optimization_guide::model_execution::prefs::
RegisterLegacyUsagePrefsForMigration(registry);
+
+ // Deprecated 11/2024
+ registry->RegisterBooleanPref(kQuietNotificationPermissionPromoWasShown,
+ true);
+ registry->RegisterBooleanPref(kQuietNotificationPermissionShouldShowPromo,
+ true);
}
void ClearSyncRequestedPrefAndMaybeMigrate(PrefService* profile_prefs) {
@@ -3006,6 +3020,10 @@
profile_prefs->ClearPref(kDiscountConsentShowInterestIn);
#endif // !BUILDFLAG(IS_ANDROID)
+ // Added 11/2024
+ profile_prefs->ClearPref(kQuietNotificationPermissionPromoWasShown);
+ profile_prefs->ClearPref(kQuietNotificationPermissionShouldShowPromo);
+
// Please don't delete the following line. It is used by PRESUBMIT.py.
// END_MIGRATE_OBSOLETE_PROFILE_PREFS
