Replace const std::string& with string_view for aggregation_service
This is now preferred. Also updates some Private Aggregation unittests
to match and some constexpr char arrays. Sql queries are also adapted
to use base::c_stringview instead of char*.
Change-Id: If96577d9cf67e49a60c54fa34b1762f8f2d60d0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5783696
Reviewed-by: Qingxin Wu <[email protected]>
Reviewed-by: Nan Lin <[email protected]>
Commit-Queue: Alex Turner <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1341913}
diff --git a/components/aggregation_service/aggregation_coordinator_utils.cc b/components/aggregation_service/aggregation_coordinator_utils.cc
index a2240e00..75a362a7 100644
--- a/components/aggregation_service/aggregation_coordinator_utils.cc
+++ b/components/aggregation_service/aggregation_coordinator_utils.cc
@@ -4,7 +4,6 @@
#include "components/aggregation_service/aggregation_coordinator_utils.h"
-#include <string>
#include <string_view>
#include <utility>
#include <vector>
@@ -28,7 +27,7 @@
url::Origin::Create(GURL(kDefaultAggregationCoordinatorGcpCloud))};
}
-std::vector<url::Origin> Parse(const std::string& unparsed) {
+std::vector<url::Origin> Parse(std::string_view unparsed) {
std::vector<url::Origin> parsed;
std::vector<std::string_view> tokens = base::SplitStringPiece(
@@ -53,7 +52,7 @@
CoordinatorOrigins() = default;
~CoordinatorOrigins() = default;
- explicit CoordinatorOrigins(const std::string& unparsed)
+ explicit CoordinatorOrigins(std::string_view unparsed)
: CoordinatorOrigins(Parse(unparsed)) {}
explicit CoordinatorOrigins(std::vector<url::Origin> origins)
