Log SharingMessage histograms with message type suffix.
Bug: 1010515
Change-Id: If62345aba1aed10d3e679140ee66aeb2f074115f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841331
Reviewed-by: Ilya Sherman <[email protected]>
Reviewed-by: Alex Chau <[email protected]>
Commit-Queue: Michael van Ouwerkerk <[email protected]>
Auto-Submit: Michael van Ouwerkerk <[email protected]>
Cr-Commit-Position: refs/heads/master@{#706831}
diff --git a/chrome/browser/sharing/ack_message_handler_unittest.cc b/chrome/browser/sharing/ack_message_handler_unittest.cc
index 6addf3d..1a3cb39 100644
--- a/chrome/browser/sharing/ack_message_handler_unittest.cc
+++ b/chrome/browser/sharing/ack_message_handler_unittest.cc
@@ -11,13 +11,20 @@
class TestObserver : public AckMessageHandler::AckMessageObserver {
public:
- void OnAckReceived(const std::string& message_id) override {
+ void OnAckReceived(chrome_browser_sharing::MessageType message_type,
+ const std::string& message_id) override {
+ received_message_type_ = message_type;
received_message_id_ = message_id;
}
+ chrome_browser_sharing::MessageType received_message_type() const {
+ return received_message_type_;
+ }
+
std::string received_message_id() const { return received_message_id_; }
private:
+ chrome_browser_sharing::MessageType received_message_type_;
std::string received_message_id_;
};
@@ -37,8 +44,12 @@
chrome_browser_sharing::SharingMessage sharing_message;
sharing_message.mutable_ack_message()->set_original_message_id(
kTestMessageId);
+ sharing_message.mutable_ack_message()->set_original_message_type(
+ chrome_browser_sharing::CLICK_TO_CALL_MESSAGE);
ack_message_handler_.OnMessage(sharing_message);
EXPECT_EQ(kTestMessageId, test_observer_.received_message_id());
+ EXPECT_EQ(chrome_browser_sharing::CLICK_TO_CALL_MESSAGE,
+ test_observer_.received_message_type());
}
