| commit | 8c70a444797ef792681f77687d1ef070a0faf6d4 | [log] [tgz] |
|---|---|---|
| author | danakj <[email protected]> | Tue Dec 10 22:48:24 2019 |
| committer | Commit Bot <[email protected]> | Tue Dec 10 22:48:24 2019 |
| tree | 0d90fdad3faaaf12c9127fe498d70d9f64811303 | |
| parent | 3aa67797606c73e38f6e10d3ffc8ce690cd1c20f [diff] [blame] |
Convert ShouldOpenDownload callbacks to OnceCallbacks. These callbacks are run once, though only if ShouldOpenDownload() returns false. Note that some implementations return false but still don't run the callback, which violates the contract defined in the DownloadManagerDelegate header. This adds TODOs in those places. [email protected], [email protected] TBR=servolk Bug: 1007763 Change-Id: Iae4e741fe4cc1a6d5c308e7608a4805cc4f17efb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959542 Commit-Queue: danakj <[email protected]> Reviewed-by: Avi Drissman <[email protected]> Reviewed-by: Min Qin <[email protected]> Cr-Commit-Position: refs/heads/master@{#723558}
diff --git a/content/shell/browser/shell_download_manager_delegate.cc b/content/shell/browser/shell_download_manager_delegate.cc index 31f5fa2b..0b6a17f 100644 --- a/content/shell/browser/shell_download_manager_delegate.cc +++ b/content/shell/browser/shell_download_manager_delegate.cc
@@ -98,7 +98,7 @@ bool ShellDownloadManagerDelegate::ShouldOpenDownload( download::DownloadItem* item, - const DownloadOpenDelayedCallback& callback) { + DownloadOpenDelayedCallback callback) { return true; }