Reland "Enable SkiaRenderer for Chrome OS trybots"
This reverts commit baa02522d88d6a2240df9177f34da7250f823de2.
skia_renderer_ash_unittests are failing due to flakes in various animation-y tests. These are already tracked in b/195938162 with a proposed solution, but the fix has not landed yet. These failures are not correctness issues, but rather result from implementation differences in the GLRenderer and SkiaRenderer test environments).
I'm inclined to resubmit the original change with skia_renderer_ash_unittests removed, since our primary focus right now is getting meaningful UMA data on M94 beta. Of course, we will make sure ash_unittests is deflaked before rolling into stable, but I don't want to block that on fixing the test environment.
Original change's description:
> Revert "Enable SkiaRenderer for Chrome OS trybots"
>
> This reverts commit 93715c694939056aae3569aa42ba40eed3880b1d.
>
> Reason for revert:
> skia_renderer_ash_unittests is failing on multiple bots:
> https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/40525/overview
> https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/25033/overview
> https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/24573/overview
> https://ci.chromium.org/ui/p/chrome/builders/ci/linux-chromeos-chrome/16545/overview
>
>
> Original change's description:
> > Enable SkiaRenderer for Chrome OS trybots
> >
> > This CL enables SkiaRenderer by default on the CQ by adding
> > "chromeos" to the UseSkiaRenderer config in
> > fieldtrial_testing_config.json in preparation for a launch to beta
> > as per go/finch-best-practices. Until SkiaRenderer is fully launched
> > on Chrome OS, however, we want to retain coverage of GLRenderer as
> > well for the same reasons mentioned in the CL that enabled
> > SkiaRenderer for MacOS trybots [1]. In addition, this CL explicitly
> > adds a SkiaRenderer variant for a few additional test suites that
> > are guarded directly by base::Feature instead of the field trial
> > testing config.
> >
> > In total, this CL adds the following new targets:
> >
> > - GLRenderer GPU telemetry tests (only on VM builders due to
> > capacity issues)
> > - SkiaRenderer webgl_conformance_tests, telemetry_unittests,
> > and telemetry_perf_unittests (run on
> > chromeos-amd64-generic-rel)
> > - SkiaRenderer ash_unittests and aura_unittests (run on
> > linux-chromeos-rel)
> >
> > [1] https://chromium-review.googlesource.com/c/chromium/src/+/2648851
> >
> > Bug: b:192562980, b:195938645
> > Change-Id: Ib50b4bc6be30c0767f4a311630dc6c73d35399a1
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3082904
> > Reviewed-by: Brian Sheedy <[email protected]>
> > Commit-Queue: Brian Ho <[email protected]>
> > Cr-Commit-Position: refs/heads/master@{#911168}
>
> Bug: b:192562980, b:195938645
> Change-Id: Id9aa4b3c30ceefc648575616362c461528541c08
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3090887
> Owners-Override: Takumi Fujimoto <[email protected]>
> Auto-Submit: Takumi Fujimoto <[email protected]>
> Commit-Queue: Rubber Stamper <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#911350}
Bug: b:192562980, b:195938645
Change-Id: Ia0e5e4cb683bbf1debff3c491397edbb10a35626
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3088549
Commit-Queue: Brian Ho <[email protected]>
Reviewed-by: Ben Pastene <[email protected]>
Reviewed-by: Brian Sheedy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#911475}
diff --git a/testing/buildbot/test_suite_exceptions.pyl b/testing/buildbot/test_suite_exceptions.pyl
index e40e78ae..1b2ebba 100644
--- a/testing/buildbot/test_suite_exceptions.pyl
+++ b/testing/buildbot/test_suite_exceptions.pyl
@@ -1564,6 +1564,51 @@
'Linux Chromium OS ASan LSan Tests (1)', # https://crbug.com/831667
],
},
+ # TODO(crbug.com/1202958): Remove these GLRenderer variants when
+ # SkiaRenderer is fully shipped on Chrome OS.
+ # Don't run these on real devices due to capacity issues.
+ 'gl_renderer_context_lost_tests': {
+ 'remove_from': [
+ 'ChromeOS FYI Release (kevin)',
+ 'Lacros FYI x64 Release (Intel)',
+ ],
+ },
+ 'gl_renderer_depth_capture_tests': {
+ 'remove_from': [
+ 'ChromeOS FYI Release (kevin)',
+ 'Lacros FYI x64 Release (Intel)',
+ ],
+ },
+ 'gl_renderer_gpu_process_launch_tests': {
+ 'remove_from': [
+ 'ChromeOS FYI Release (kevin)',
+ 'Lacros FYI x64 Release (Intel)',
+ ],
+ },
+ 'gl_renderer_hardware_accelerated_feature_tests': {
+ 'remove_from': [
+ 'ChromeOS FYI Release (kevin)',
+ 'Lacros FYI x64 Release (Intel)',
+ ],
+ },
+ 'gl_renderer_maps_pixel_tests': {
+ 'remove_from': [
+ 'ChromeOS FYI Release (kevin)',
+ 'Lacros FYI x64 Release (Intel)',
+ ],
+ },
+ 'gl_renderer_pixel_skia_gold_tests': {
+ 'remove_from': [
+ 'ChromeOS FYI Release (kevin)',
+ 'Lacros FYI x64 Release (Intel)',
+ ],
+ },
+ 'gl_renderer_screenshot_sync_tests': {
+ 'remove_from': [
+ 'ChromeOS FYI Release (kevin)',
+ 'Lacros FYI x64 Release (Intel)',
+ ],
+ },
'gl_tests_passthrough': {
'remove_from': [
'CFI Linux ToT',
@@ -2582,6 +2627,50 @@
},
}
},
+ # TODO(crbug.com/1202958): Remove these when SkiaRenderer is fully shipped
+ # on Chrome OS.
+ 'skia_renderer_telemetry_perf_unittests': {
+ 'remove_from': [
+ # Not enough capacity.
+ 'chromeos-betty-pi-arc-chrome',
+ 'chromeos-betty-pi-arc-chrome-dchecks',
+ ],
+ 'modifications': {
+ 'chromeos-amd64-generic-rel': {
+ 'ci_only': True,
+ },
+ 'chromeos-amd64-generic-rel (goma cache silo)': {
+ 'ci_only': True,
+ },
+ 'chromeos-amd64-generic-rel (reclient)': {
+ 'ci_only': True,
+ },
+ 'chromeos-amd64-generic-rel-dchecks': {
+ 'ci_only': True,
+ },
+ },
+ },
+ 'skia_renderer_telemetry_unittests': {
+ 'remove_from': [
+ # Not enough capacity.
+ 'chromeos-betty-pi-arc-chrome',
+ 'chromeos-betty-pi-arc-chrome-dchecks',
+ ],
+ 'modifications': {
+ 'chromeos-amd64-generic-rel': {
+ 'ci_only': True,
+ },
+ 'chromeos-amd64-generic-rel (goma cache silo)': {
+ 'ci_only': True,
+ },
+ 'chromeos-amd64-generic-rel (reclient)': {
+ 'ci_only': True,
+ },
+ 'chromeos-amd64-generic-rel-dchecks': {
+ 'ci_only': True,
+ },
+ },
+ },
'swiftshader_unittests': {
'remove_from': [
# Save capacity on the hardware where we have only a few machines.
