Rename Mixed Download Blocking to Insecure Download Blocking
This CL has have no functional effect -- Chrome should work identically after this CL lands.
This CL renames mixed download blocking to insecure download blocking in
preparation for future work to allow blocking of all *insecure* downloads.
Mixed downloads _are_ insecure downloads, so even without additional changes, the new name is still accurate.
Bug: 1352598
Change-Id: Ie66c98966bc1f4000bfbc4df7d670506fb960e9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4072471
Reviewed-by: John Abd-El-Malek <[email protected]>
Reviewed-by: Evan Stade <[email protected]>
Reviewed-by: David Black <[email protected]>
Reviewed-by: Mustafa Emre Acer <[email protected]>
Reviewed-by: Sean Topping <[email protected]>
Reviewed-by: John Lee <[email protected]>
Commit-Queue: Joe DeBlasio <[email protected]>
Reviewed-by: Andrey Kosyakov <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: danakj <[email protected]>
Reviewed-by: Min Qin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1082052}
diff --git a/content/shell/browser/shell_download_manager_delegate.cc b/content/shell/browser/shell_download_manager_delegate.cc
index 712d03ee..cd63d92 100644
--- a/content/shell/browser/shell_download_manager_delegate.cc
+++ b/content/shell/browser/shell_download_manager_delegate.cc
@@ -77,7 +77,7 @@
download->GetForcedFilePath(),
download::DownloadItem::TARGET_DISPOSITION_OVERWRITE,
download::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS,
- download::DownloadItem::MixedContentStatus::UNKNOWN,
+ download::DownloadItem::InsecureDownloadStatus::UNKNOWN,
download->GetForcedFilePath(), base::FilePath(),
std::string() /*mime_type*/, download::DOWNLOAD_INTERRUPT_REASON_NONE);
return true;
@@ -143,7 +143,7 @@
std::move(callback).Run(
suggested_path, download::DownloadItem::TARGET_DISPOSITION_OVERWRITE,
download::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS,
- download::DownloadItem::MixedContentStatus::UNKNOWN,
+ download::DownloadItem::InsecureDownloadStatus::UNKNOWN,
suggested_path.AddExtension(FILE_PATH_LITERAL(".crdownload")),
base::FilePath(), std::string() /*mime_type*/,
download::DOWNLOAD_INTERRUPT_REASON_NONE);
@@ -193,12 +193,12 @@
NOTIMPLEMENTED();
#endif
- std::move(callback).Run(result,
- download::DownloadItem::TARGET_DISPOSITION_PROMPT,
- download::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS,
- download::DownloadItem::MixedContentStatus::UNKNOWN,
- result, base::FilePath(), std::string() /*mime_type*/,
- download::DOWNLOAD_INTERRUPT_REASON_NONE);
+ std::move(callback).Run(
+ result, download::DownloadItem::TARGET_DISPOSITION_PROMPT,
+ download::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS,
+ download::DownloadItem::InsecureDownloadStatus::UNKNOWN, result,
+ base::FilePath(), std::string() /*mime_type*/,
+ download::DOWNLOAD_INTERRUPT_REASON_NONE);
}
void ShellDownloadManagerDelegate::SetDownloadBehaviorForTesting(
