Exclude top of NOTREACHED tail still hit in stable
This includes the top ~30 in M128 and ~20 in M127 on ChromeOS.
... except the few ones I can't find due to ICF, or ones that have
already been fixed or removed as erroneous.
This is to further derisk NOTREACHED-fatal rollout. Per crash-reporting
volumes on Windows we should be about 1/50 as crashy as CHECK failures
after this has landed.
40264195, 40895492, 354661907, 363109548, 361609999, 352381196,
361612971, 362124606, 355803743, 41369768, 345232410, 346893376,
40910294
Bug: 40580068, 332263206, 40942310, 40948203, 355803743, 362506636,
Change-Id: I56e42b3b7c8ce17d6dabb5d7edb48db925240e34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5824114
Owners-Override: Lei Zhang <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Code-Coverage: [email protected] <[email protected]>
Commit-Queue: Peter Boström <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1349061}
diff --git a/chrome/browser/ash/login/signin/token_handle_util.cc b/chrome/browser/ash/login/signin/token_handle_util.cc
index 6f00f37d..0ea4f64 100644
--- a/chrome/browser/ash/login/signin/token_handle_util.cc
+++ b/chrome/browser/ash/login/signin/token_handle_util.cc
@@ -242,7 +242,7 @@
const user_manager::User* user =
user_manager::UserManager::Get()->FindUser(account_id);
if (!user) {
- NOTREACHED_IN_MIGRATION() << "Invalid user";
+ DUMP_WILL_BE_NOTREACHED() << "Invalid user";
FinishWithStatus(std::move(callback), token, account_id, status,
/*user_has_gaia_password=*/true);
return;
diff --git a/chrome/browser/cart/cart_discount_fetcher.cc b/chrome/browser/cart/cart_discount_fetcher.cc
index b5582188..08c1a5c 100644
--- a/chrome/browser/cart/cart_discount_fetcher.cc
+++ b/chrome/browser/cart/cart_discount_fetcher.cc
@@ -326,12 +326,12 @@
bool ValidateResponse(const std::optional<base::Value>& response) {
if (!response) {
- NOTREACHED_IN_MIGRATION() << "Response is not valid";
+ DUMP_WILL_BE_NOTREACHED() << "Response is not valid";
return false;
}
if (!response->is_dict()) {
- NOTREACHED_IN_MIGRATION()
+ DUMP_WILL_BE_NOTREACHED()
<< "Wrong response format, response is not a dictionary. Response: "
<< response->DebugString();
return false;
diff --git a/chrome/browser/download/notification/download_item_notification.cc b/chrome/browser/download/notification/download_item_notification.cc
index 1da8a23..69e1ac70 100644
--- a/chrome/browser/download/notification/download_item_notification.cc
+++ b/chrome/browser/download/notification/download_item_notification.cc
@@ -1006,7 +1006,7 @@
case download::DOWNLOAD_DANGER_TYPE_PROMPT_FOR_LOCAL_PASSWORD_SCANNING:
case download::DOWNLOAD_DANGER_TYPE_ASYNC_LOCAL_PASSWORD_SCANNING: {
// TODO(crbug.com/40074456): Implement UX for this danger type.
- NOTREACHED_IN_MIGRATION();
+ DUMP_WILL_BE_NOTREACHED();
break;
}
case download::DOWNLOAD_DANGER_TYPE_BLOCKED_SCAN_FAILED: {
diff --git a/chrome/browser/extensions/extension_context_menu_model.cc b/chrome/browser/extensions/extension_context_menu_model.cc
index 3335c1e47..1c528df 100644
--- a/chrome/browser/extensions/extension_context_menu_model.cc
+++ b/chrome/browser/extensions/extension_context_menu_model.cc
@@ -165,7 +165,7 @@
default:
break;
}
- NOTREACHED_IN_MIGRATION();
+ DUMP_WILL_BE_NOTREACHED();
return ContextMenuAction::kNoAction;
}
diff --git a/chrome/browser/first_run/upgrade_util_win.cc b/chrome/browser/first_run/upgrade_util_win.cc
index 734c88f..6ccdc7b 100644
--- a/chrome/browser/first_run/upgrade_util_win.cc
+++ b/chrome/browser/first_run/upgrade_util_win.cc
@@ -402,7 +402,7 @@
// At this point the chrome.exe has been swapped with the new one.
if (!RelaunchChromeBrowser(command_line)) {
// The relaunch failed. Feel free to panic now.
- NOTREACHED_IN_MIGRATION();
+ DUMP_WILL_BE_NOTREACHED();
}
return true;
}
diff --git a/chrome/browser/ui/views/permissions/chip/permission_dashboard_controller.cc b/chrome/browser/ui/views/permissions/chip/permission_dashboard_controller.cc
index 7dfeb25f..9da33ed 100644
--- a/chrome/browser/ui/views/permissions/chip/permission_dashboard_controller.cc
+++ b/chrome/browser/ui/views/permissions/chip/permission_dashboard_controller.cc
@@ -577,7 +577,7 @@
return l10n_util::GetStringUTF16(IDS_MICROPHONE_NOT_ALLOWED);
}
- NOTREACHED_IN_MIGRATION();
+ DUMP_WILL_BE_NOTREACHED();
return std::u16string();
}
diff --git a/chrome/browser/ui/webui/ash/cloud_upload/cloud_upload_dialog.cc b/chrome/browser/ui/webui/ash/cloud_upload/cloud_upload_dialog.cc
index 465c536..2fd96fa 100644
--- a/chrome/browser/ui/webui/ash/cloud_upload/cloud_upload_dialog.cc
+++ b/chrome/browser/ui/webui/ash/cloud_upload/cloud_upload_dialog.cc
@@ -368,7 +368,7 @@
std::unique_ptr<ash::cloud_upload::CloudOpenMetrics> cloud_open_metrics,
std::optional<const std::string> choice) {
if (!IsOpenInOfficeTask(task)) {
- NOTREACHED_IN_MIGRATION();
+ DUMP_WILL_BE_NOTREACHED();
return;
}
diff --git a/chrome/browser/web_applications/os_integration/web_app_uninstallation_via_os_settings_registration.cc b/chrome/browser/web_applications/os_integration/web_app_uninstallation_via_os_settings_registration.cc
index 6284c96..e7e1465d 100644
--- a/chrome/browser/web_applications/os_integration/web_app_uninstallation_via_os_settings_registration.cc
+++ b/chrome/browser/web_applications/os_integration/web_app_uninstallation_via_os_settings_registration.cc
@@ -29,7 +29,7 @@
bool UnregisterUninstallationViaOsSettingsWithOs(
const webapps::AppId& app_id,
const base::FilePath& profile_path) {
- NOTREACHED_IN_MIGRATION();
+ DUMP_WILL_BE_NOTREACHED();
return true;
}
