Remove dead code in ChromeNavigationUIData
ChromeNavigationUIData::window_open_disposition is only checked by tests
(which are also removed by this CL).
Bug: None
Change-Id: I56d0390ec6adf7b732137fe61b5be0db8d5eae16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6451812
Commit-Queue: Kevin McNee <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Reviewed-by: Giovanni Ortuno Urquidi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1446677}
diff --git a/chrome/browser/renderer_host/chrome_navigation_ui_data.cc b/chrome/browser/renderer_host/chrome_navigation_ui_data.cc
index dafef6b7..a520f64 100644
--- a/chrome/browser/renderer_host/chrome_navigation_ui_data.cc
+++ b/chrome/browser/renderer_host/chrome_navigation_ui_data.cc
@@ -8,19 +8,16 @@
#include "components/no_state_prefetch/browser/no_state_prefetch_contents.h"
#include "content/public/browser/navigation_handle.h"
#include "extensions/buildflags/buildflags.h"
-#include "ui/base/window_open_disposition.h"
#if BUILDFLAG(ENABLE_EXTENSIONS)
#include "extensions/browser/extensions_browser_client.h"
#include "extensions/common/constants.h"
#endif
-ChromeNavigationUIData::ChromeNavigationUIData()
- : disposition_(WindowOpenDisposition::CURRENT_TAB) {}
+ChromeNavigationUIData::ChromeNavigationUIData() = default;
ChromeNavigationUIData::ChromeNavigationUIData(
- content::NavigationHandle* navigation_handle)
- : disposition_(WindowOpenDisposition::CURRENT_TAB) {
+ content::NavigationHandle* navigation_handle) {
auto* web_contents = navigation_handle->GetWebContents();
#if BUILDFLAG(ENABLE_EXTENSIONS)
int tab_id = extension_misc::kUnknownTabId;
@@ -48,11 +45,9 @@
std::unique_ptr<ChromeNavigationUIData>
ChromeNavigationUIData::CreateForMainFrameNavigation(
content::WebContents* web_contents,
- WindowOpenDisposition disposition,
bool is_using_https_as_default_scheme,
bool force_no_https_upgrade) {
auto navigation_ui_data = std::make_unique<ChromeNavigationUIData>();
- navigation_ui_data->disposition_ = disposition;
navigation_ui_data->is_using_https_as_default_scheme_ =
is_using_https_as_default_scheme;
navigation_ui_data->force_no_https_upgrade_ = force_no_https_upgrade;
@@ -77,7 +72,6 @@
std::unique_ptr<content::NavigationUIData> ChromeNavigationUIData::Clone() {
auto copy = std::make_unique<ChromeNavigationUIData>();
- copy->disposition_ = disposition_;
copy->is_using_https_as_default_scheme_ = is_using_https_as_default_scheme_;
copy->force_no_https_upgrade_ = force_no_https_upgrade_;
