components: default the user-defined empty ctor and dtor where possible
I need an owner's approval please for changes under:
components/nacl
This is a mechanical change. There are a few instances (but not all)
of empty user-defined constructors and destructors which can be
defaulted in the /components code.
This CL was uploaded by git cl split.
[email protected]
Bug: 371316188
Change-Id: Ic4bd192e305b3bc62d2fff2f97be4da571b2334e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5918054
Commit-Queue: Derek Schuff <[email protected]>
Reviewed-by: Derek Schuff <[email protected]>
Auto-Submit: Sorin Jianu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1366450}
diff --git a/components/nacl/browser/nacl_browser_delegate.h b/components/nacl/browser/nacl_browser_delegate.h
index 495fda9f..90df865 100644
--- a/components/nacl/browser/nacl_browser_delegate.h
+++ b/components/nacl/browser/nacl_browser_delegate.h
@@ -27,7 +27,7 @@
// otherwise noted.
class NaClBrowserDelegate {
public:
- virtual ~NaClBrowserDelegate() {}
+ virtual ~NaClBrowserDelegate() = default;
// Show an infobar to the user to indicate the client architecture was not
// covered by the manifest.
diff --git a/components/nacl/browser/nacl_file_host_unittest.cc b/components/nacl/browser/nacl_file_host_unittest.cc
index f866de7..3081343 100644
--- a/components/nacl/browser/nacl_file_host_unittest.cc
+++ b/components/nacl/browser/nacl_file_host_unittest.cc
@@ -19,7 +19,7 @@
class FileHostTestNaClBrowserDelegate : public TestNaClBrowserDelegate {
public:
- FileHostTestNaClBrowserDelegate() {}
+ FileHostTestNaClBrowserDelegate() = default;
bool GetPnaclDirectory(base::FilePath* pnacl_dir) override {
*pnacl_dir = pnacl_path_;
diff --git a/components/nacl/browser/nacl_process_host.cc b/components/nacl/browser/nacl_process_host.cc
index a631edb..6806fe5 100644
--- a/components/nacl/browser/nacl_process_host.cc
+++ b/components/nacl/browser/nacl_process_host.cc
@@ -94,7 +94,7 @@
class NaClSandboxedProcessLauncherDelegate
: public content::SandboxedProcessLauncherDelegate {
public:
- NaClSandboxedProcessLauncherDelegate() {}
+ NaClSandboxedProcessLauncherDelegate() = default;
#if BUILDFLAG(USE_ZYGOTE)
content::ZygoteCommunication* GetZygote() override {
diff --git a/components/nacl/browser/pnacl_translation_cache.cc b/components/nacl/browser/pnacl_translation_cache.cc
index deacf3e..27389d1 100644
--- a/components/nacl/browser/pnacl_translation_cache.cc
+++ b/components/nacl/browser/pnacl_translation_cache.cc
@@ -334,7 +334,7 @@
// Construction and cache backend initialization
PnaclTranslationCache::PnaclTranslationCache() : in_memory_(false) {}
-PnaclTranslationCache::~PnaclTranslationCache() {}
+PnaclTranslationCache::~PnaclTranslationCache() = default;
int PnaclTranslationCache::Init(net::CacheType cache_type,
const base::FilePath& cache_dir,
diff --git a/components/nacl/browser/pnacl_translation_cache_unittest.cc b/components/nacl/browser/pnacl_translation_cache_unittest.cc
index ef547f9..6068f51 100644
--- a/components/nacl/browser/pnacl_translation_cache_unittest.cc
+++ b/components/nacl/browser/pnacl_translation_cache_unittest.cc
@@ -29,7 +29,7 @@
protected:
PnaclTranslationCacheTest()
: task_environment_(content::BrowserTaskEnvironment::IO_MAINLOOP) {}
- ~PnaclTranslationCacheTest() override {}
+ ~PnaclTranslationCacheTest() override = default;
void SetUp() override { cache_ = std::make_unique<PnaclTranslationCache>(); }
void TearDown() override {
// The destructor of PnaclTranslationCacheWriteEntry posts a task to the IO
diff --git a/components/nacl/browser/test_nacl_browser_delegate.cc b/components/nacl/browser/test_nacl_browser_delegate.cc
index 4717d176..cb90ae8 100644
--- a/components/nacl/browser/test_nacl_browser_delegate.cc
+++ b/components/nacl/browser/test_nacl_browser_delegate.cc
@@ -5,9 +5,9 @@
#include "components/nacl/browser/test_nacl_browser_delegate.h"
#include "base/functional/callback.h"
-TestNaClBrowserDelegate::TestNaClBrowserDelegate() {}
+TestNaClBrowserDelegate::TestNaClBrowserDelegate() = default;
-TestNaClBrowserDelegate::~TestNaClBrowserDelegate() {}
+TestNaClBrowserDelegate::~TestNaClBrowserDelegate() = default;
void TestNaClBrowserDelegate::ShowMissingArchInfobar(int render_process_id,
int render_frame_id) {}
diff --git a/components/nacl/common/pnacl_types.cc b/components/nacl/common/pnacl_types.cc
index e40c5c7fd..c542ee35 100644
--- a/components/nacl/common/pnacl_types.cc
+++ b/components/nacl/common/pnacl_types.cc
@@ -12,6 +12,6 @@
has_no_store_header(false),
use_subzero(false) {}
PnaclCacheInfo::PnaclCacheInfo(const PnaclCacheInfo& other) = default;
-PnaclCacheInfo::~PnaclCacheInfo() {}
+PnaclCacheInfo::~PnaclCacheInfo() = default;
} // namespace nacl
diff --git a/components/nacl/loader/nacl_ipc_adapter.cc b/components/nacl/loader/nacl_ipc_adapter.cc
index 12074463..586b42f 100644
--- a/components/nacl/loader/nacl_ipc_adapter.cc
+++ b/components/nacl/loader/nacl_ipc_adapter.cc
@@ -266,7 +266,7 @@
class NaClIPCAdapter::RewrittenMessage {
public:
RewrittenMessage();
- ~RewrittenMessage() {}
+ ~RewrittenMessage() = default;
bool is_consumed() const { return data_read_cursor_ == data_len_; }
diff --git a/components/nacl/loader/nacl_ipc_adapter_unittest.cc b/components/nacl/loader/nacl_ipc_adapter_unittest.cc
index 2f8ec66..6f2241bc 100644
--- a/components/nacl/loader/nacl_ipc_adapter_unittest.cc
+++ b/components/nacl/loader/nacl_ipc_adapter_unittest.cc
@@ -31,7 +31,7 @@
class NaClIPCAdapterTest : public testing::Test {
public:
- NaClIPCAdapterTest() {}
+ NaClIPCAdapterTest() = default;
// testing::Test implementation.
void SetUp() override {
diff --git a/components/nacl/loader/nacl_listener.cc b/components/nacl/loader/nacl_listener.cc
index 926a376..bbd372c 100644
--- a/components/nacl/loader/nacl_listener.cc
+++ b/components/nacl/loader/nacl_listener.cc
@@ -196,7 +196,7 @@
g_listener->OnFileTokenResolved(token_lo, token_hi, ipc_fd, file_path);
}
private:
- ~FileTokenMessageFilter() override {}
+ ~FileTokenMessageFilter() override = default;
};
void NaClListener::Listen() {
diff --git a/components/nacl/loader/nacl_validation_db.h b/components/nacl/loader/nacl_validation_db.h
index 4efc574..4b1680a 100644
--- a/components/nacl/loader/nacl_validation_db.h
+++ b/components/nacl/loader/nacl_validation_db.h
@@ -9,12 +9,12 @@
class NaClValidationDB {
public:
- NaClValidationDB() {}
+ NaClValidationDB() = default;
NaClValidationDB(const NaClValidationDB&) = delete;
NaClValidationDB& operator=(const NaClValidationDB&) = delete;
- virtual ~NaClValidationDB() {}
+ virtual ~NaClValidationDB() = default;
virtual bool QueryKnownToValidate(const std::string& signature) = 0;
virtual void SetKnownToValidate(const std::string& signature) = 0;
diff --git a/components/nacl/loader/sandbox_linux/nacl_bpf_sandbox_linux.cc b/components/nacl/loader/sandbox_linux/nacl_bpf_sandbox_linux.cc
index 1b1d6ad..8ab7d8ec 100644
--- a/components/nacl/loader/sandbox_linux/nacl_bpf_sandbox_linux.cc
+++ b/components/nacl/loader/sandbox_linux/nacl_bpf_sandbox_linux.cc
@@ -60,7 +60,7 @@
NaClBPFSandboxPolicy(const NaClBPFSandboxPolicy&) = delete;
NaClBPFSandboxPolicy& operator=(const NaClBPFSandboxPolicy&) = delete;
- ~NaClBPFSandboxPolicy() override {}
+ ~NaClBPFSandboxPolicy() override = default;
ResultExpr EvaluateSyscall(int system_call_number) const override;
ResultExpr InvalidSyscall() const override {
diff --git a/components/nacl/renderer/json_manifest.cc b/components/nacl/renderer/json_manifest.cc
index f9eb060c..f2c9b55 100644
--- a/components/nacl/renderer/json_manifest.cc
+++ b/components/nacl/renderer/json_manifest.cc
@@ -382,7 +382,7 @@
sandbox_isa_(sandbox_isa),
pnacl_debug_(pnacl_debug) {}
-JsonManifest::~JsonManifest() {}
+JsonManifest::~JsonManifest() = default;
bool JsonManifest::Init(const std::string& manifest_json_data,
ErrorInfo* error_info) {
diff --git a/components/nacl/renderer/manifest_service_channel.h b/components/nacl/renderer/manifest_service_channel.h
index 9807254e..a19055d 100644
--- a/components/nacl/renderer/manifest_service_channel.h
+++ b/components/nacl/renderer/manifest_service_channel.h
@@ -35,7 +35,7 @@
class Delegate {
public:
- virtual ~Delegate() {}
+ virtual ~Delegate() = default;
// Called when PPAPI initialization in the NaCl plugin is finished.
virtual void StartupInitializationComplete() = 0;
diff --git a/components/nacl/renderer/nacl_helper.cc b/components/nacl/renderer/nacl_helper.cc
index 489a9611..d9f734f6 100644
--- a/components/nacl/renderer/nacl_helper.cc
+++ b/components/nacl/renderer/nacl_helper.cc
@@ -11,7 +11,7 @@
NaClHelper::NaClHelper(content::RenderFrame* render_frame)
: RenderFrameObserver(render_frame) {}
-NaClHelper::~NaClHelper() {}
+NaClHelper::~NaClHelper() = default;
void NaClHelper::DidCreatePepperPlugin(content::RendererPpapiHost* host) {
// The Native Client plugin is a host for external plugins.
diff --git a/components/nacl/renderer/ppb_nacl_private_impl.cc b/components/nacl/renderer/ppb_nacl_private_impl.cc
index 290f939..e453f0c 100644
--- a/components/nacl/renderer/ppb_nacl_private_impl.cc
+++ b/components/nacl/renderer/ppb_nacl_private_impl.cc
@@ -232,7 +232,7 @@
ManifestServiceProxy(const ManifestServiceProxy&) = delete;
ManifestServiceProxy& operator=(const ManifestServiceProxy&) = delete;
- ~ManifestServiceProxy() override {}
+ ~ManifestServiceProxy() override = default;
void StartupInitializationComplete() override {
if (StartPpapiProxy(pp_instance_) == PP_TRUE) {
