Remove Lite Page Redirect Preview Code
This preview type (known as LPR) is a rather heavy-weight page
optimization that is being turned down on the server side and so the
code can be fully removed now in Chromium.
Notes:
* This preview rewrote the displayed URL in the Omnibox and in History.
* This preview used page_id in ChromeUINavigationData, which is no
longer needed and is removed.
* This preview had tight integration with DataReductionProxy which is
also being turned down. Sorry for the merge conflicts.
Bug: 1073125
Change-Id: I53b11defbf8bccbe44038fe198b656a762a5b060
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161311
Commit-Queue: Robert Ogden <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Ryan Sturm <[email protected]>
Reviewed-by: Christian Dullweber <[email protected]>
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Tarun Bansal <[email protected]>
Cr-Commit-Position: refs/heads/master@{#763591}
diff --git a/chrome/browser/renderer_host/chrome_navigation_ui_data.cc b/chrome/browser/renderer_host/chrome_navigation_ui_data.cc
index b2bd3d47..368d9d13 100644
--- a/chrome/browser/renderer_host/chrome_navigation_ui_data.cc
+++ b/chrome/browser/renderer_host/chrome_navigation_ui_data.cc
@@ -6,7 +6,6 @@
#include "chrome/browser/prerender/prerender_contents.h"
#include "chrome/browser/prerender/prerender_histograms.h"
-#include "chrome/browser/previews/previews_lite_page_redirect_decider.h"
#include "content/public/browser/navigation_handle.h"
#include "extensions/buildflags/buildflags.h"
#include "ui/base/window_open_disposition.h"
@@ -43,9 +42,6 @@
prerender::PrerenderHistograms::GetHistogramPrefix(
prerender_contents->origin());
}
- data_reduction_proxy_page_id_ =
- PreviewsLitePageRedirectDecider::GeneratePageIdForWebContents(
- web_contents);
}
ChromeNavigationUIData::~ChromeNavigationUIData() {}
@@ -54,12 +50,9 @@
std::unique_ptr<ChromeNavigationUIData>
ChromeNavigationUIData::CreateForMainFrameNavigation(
content::WebContents* web_contents,
- WindowOpenDisposition disposition,
- int64_t data_reduction_proxy_page_id) {
+ WindowOpenDisposition disposition) {
auto navigation_ui_data = std::make_unique<ChromeNavigationUIData>();
navigation_ui_data->disposition_ = disposition;
- navigation_ui_data->data_reduction_proxy_page_id_ =
- data_reduction_proxy_page_id;
#if BUILDFLAG(ENABLE_EXTENSIONS)
int tab_id = extension_misc::kUnknownTabId;
@@ -82,7 +75,6 @@
auto copy = std::make_unique<ChromeNavigationUIData>();
copy->disposition_ = disposition_;
- copy->data_reduction_proxy_page_id_ = data_reduction_proxy_page_id_;
#if BUILDFLAG(ENABLE_EXTENSIONS)
if (extension_data_)
diff --git a/chrome/browser/renderer_host/chrome_navigation_ui_data.h b/chrome/browser/renderer_host/chrome_navigation_ui_data.h
index 81b9b8d..f7c2f9f 100644
--- a/chrome/browser/renderer_host/chrome_navigation_ui_data.h
+++ b/chrome/browser/renderer_host/chrome_navigation_ui_data.h
@@ -33,8 +33,7 @@
static std::unique_ptr<ChromeNavigationUIData> CreateForMainFrameNavigation(
content::WebContents* web_contents,
- WindowOpenDisposition disposition,
- int64_t data_reduction_proxy_page_id);
+ WindowOpenDisposition disposition);
// Creates a new ChromeNavigationUIData that is a deep copy of the original.
// Any changes to the original after the clone is created will not be
@@ -65,9 +64,6 @@
const std::string& prerender_histogram_prefix() {
return prerender_histogram_prefix_;
}
- uint64_t data_reduction_proxy_page_id() const {
- return data_reduction_proxy_page_id_;
- }
private:
#if BUILDFLAG(ENABLE_EXTENSIONS)
@@ -84,7 +80,6 @@
WindowOpenDisposition disposition_;
prerender::PrerenderMode prerender_mode_ = prerender::NO_PRERENDER;
std::string prerender_histogram_prefix_;
- uint64_t data_reduction_proxy_page_id_ = 0;
DISALLOW_COPY_AND_ASSIGN(ChromeNavigationUIData);
};
