Remove Lite Page Redirect Preview Code
This preview type (known as LPR) is a rather heavy-weight page
optimization that is being turned down on the server side and so the
code can be fully removed now in Chromium.
Notes:
* This preview rewrote the displayed URL in the Omnibox and in History.
* This preview used page_id in ChromeUINavigationData, which is no
longer needed and is removed.
* This preview had tight integration with DataReductionProxy which is
also being turned down. Sorry for the merge conflicts.
Bug: 1073125
Change-Id: I53b11defbf8bccbe44038fe198b656a762a5b060
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161311
Commit-Queue: Robert Ogden <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Ryan Sturm <[email protected]>
Reviewed-by: Christian Dullweber <[email protected]>
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Tarun Bansal <[email protected]>
Cr-Commit-Position: refs/heads/master@{#763591}
diff --git a/chrome/browser/prefs/browser_prefs.cc b/chrome/browser/prefs/browser_prefs.cc
index e29a6c98..9249ee1 100644
--- a/chrome/browser/prefs/browser_prefs.cc
+++ b/chrome/browser/prefs/browser_prefs.cc
@@ -56,7 +56,6 @@
#include "chrome/browser/prefs/origin_trial_prefs.h"
#include "chrome/browser/prefs/session_startup_pref.h"
#include "chrome/browser/previews/previews_https_notification_infobar_decider.h"
-#include "chrome/browser/previews/previews_lite_page_redirect_decider.h"
#include "chrome/browser/previews/previews_offline_helper.h"
#include "chrome/browser/printing/print_preview_sticky_settings.h"
#include "chrome/browser/profiles/chrome_version_service.h"
@@ -531,6 +530,12 @@
// Deprecated 4/2020
const char kExcludedSchemes[] = "protocol_handler.excluded_schemes";
+// Deprecated 4/2020
+const char kPreviewsLPRHostBlacklist[] = "previews.litepage.host-blacklist";
+const char kPreviewsLPRProbeCache[] = "Availability.Prober.cache.Litepages";
+const char kPreviewsLPROriginProbeCache[] =
+ "Availability.Prober.cache.LitepagesOriginCheck";
+
// Register local state used only for migration (clearing or moving to a new
// key).
void RegisterLocalStatePrefsForMigration(PrefRegistrySimple* registry) {
@@ -625,6 +630,9 @@
#endif // defined(OS_CHROMEOS)
registry->RegisterDictionaryPref(kExcludedSchemes);
+ registry->RegisterDictionaryPref(kPreviewsLPRHostBlacklist);
+ registry->RegisterDictionaryPref(kPreviewsLPRProbeCache);
+ registry->RegisterDictionaryPref(kPreviewsLPROriginProbeCache);
}
} // namespace
@@ -853,7 +861,6 @@
PrefProxyConfigTrackerImpl::RegisterProfilePrefs(registry);
PrefsTabHelper::RegisterProfilePrefs(registry, locale);
PreviewsHTTPSNotificationInfoBarDecider::RegisterProfilePrefs(registry);
- PreviewsLitePageRedirectDecider::RegisterProfilePrefs(registry);
PreviewsOfflineHelper::RegisterProfilePrefs(registry);
Profile::RegisterProfilePrefs(registry);
ProfileImpl::RegisterProfilePrefs(registry);
@@ -1238,4 +1245,9 @@
// Added 4/2020
profile_prefs->ClearPref(kExcludedSchemes);
+
+ // Added 4/2020.
+ profile_prefs->ClearPref(kPreviewsLPRHostBlacklist);
+ profile_prefs->ClearPref(kPreviewsLPRProbeCache);
+ profile_prefs->ClearPref(kPreviewsLPROriginProbeCache);
}
