cryptotoken: prompt when attestation is requested.
This behaviour is currently disabled by default.
For an image of what the prompt looks like, see the PRD document linked
from the bug. Wording comes from srahim@.
While this change contains strings for Android, that is for the future
when this behaviour is moved into (the unlaunched) webauthn support.
Chrome doesn't actually support U2F on Android itself – sites have to
use an intent to trigger Google Authenticator.
Bug: 793985
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia34f8cf89dbc5379330316716356a2d890e1afde
Reviewed-on: https://chromium-review.googlesource.com/834689
Reviewed-by: Adam Langley <[email protected]>
Reviewed-by: Devlin <[email protected]>
Reviewed-by: Gayane Petrosyan <[email protected]>
Reviewed-by: Timothy Loh <[email protected]>
Reviewed-by: Evan Stade <[email protected]>
Commit-Queue: Adam Langley <[email protected]>
Cr-Commit-Position: refs/heads/master@{#528226}diff --git a/chrome/browser/permissions/permission_request.h b/chrome/browser/permissions/permission_request.h
index f4473c3f..b093c8d 100644
--- a/chrome/browser/permissions/permission_request.h
+++ b/chrome/browser/permissions/permission_request.h
@@ -15,12 +15,16 @@
}
// Used for UMA to record the types of permission prompts shown.
-// This corresponds to the PermissionRequestType enum in
-// src/tools/metrics/histograms.xml. The usual rules of updating UMA values
-// applies to this enum:
+// When updating, you also need to update:
+// 1) The PermissionRequestType enum in tools/metrics/histograms/enums.xml.
+// 2) The PermissionRequestTypes suffix list in
+// tools/metrics/histograms/histograms.xml.
+// 3) GetPermissionRequestString in
+// chrome/browser/permissions/permission_uma_util.cc.
+//
+// The usual rules of updating UMA values applies to this enum:
// - don't remove values
// - only ever add values at the end
-// - keep the PermissionRequestType enum in sync with this definition.
enum class PermissionRequestType {
UNKNOWN = 0,
MULTIPLE = 1,
@@ -39,6 +43,7 @@
PERMISSION_MEDIASTREAM_CAMERA = 14,
PERMISSION_ACCESSIBILITY_EVENTS = 15,
PERMISSION_CLIPBOARD_READ = 16,
+ PERMISSION_SECURITY_KEY_ATTESTATION = 17,
// NUM must be the last value in the enum.
NUM
};
