Move App Service off Service Manager
This moves ownership of the AppServiceImpl directly into the browser's
AppServiceProxy, rather than having indirect ownership through Service
Manager and Connector.
In the original, multi-process aware App Service design, there would be
N App Service Proxies connecting to 1 App Service, where N is the number
of processes. Now that out-of-process ash is not being worked on, N:1 in
theory will remain 1:1 in practice for the foreseeable future, so the
browser process App Service Proxy can itself own the service implementation.
Bug: 977637
Change-Id: I8320dd5b642b82940f6b8697df5cb06ca5226d21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819283
Commit-Queue: Maksim Ivanov <[email protected]>
Reviewed-by: Maksim Ivanov <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Reviewed-by: Nigel Tao <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Ken Rockot <[email protected]>
Auto-Submit: Dominick Ng <[email protected]>
Cr-Commit-Position: refs/heads/master@{#699653}
diff --git a/chrome/browser/platform_util_unittest.cc b/chrome/browser/platform_util_unittest.cc
index 2d5f87a8..7d9c38e6 100644
--- a/chrome/browser/platform_util_unittest.cc
+++ b/chrome/browser/platform_util_unittest.cc
@@ -113,6 +113,11 @@
extensions::ExtensionRegistry::Get(GetProfile())->AddEnabled(extension);
}
+ void SetUp() override {
+ BrowserWithTestWindowTest::SetUp();
+ base::RunLoop().RunUntilIdle();
+ }
+
void TearDown() override {
content::ContentBrowserClient* content_browser_client =
content::SetBrowserClientForTesting(old_content_browser_client_);
@@ -151,7 +156,7 @@
static const char kTestFileData[] = "Cow says moo!";
const int kTestFileDataLength = base::size(kTestFileData) - 1;
- // This prevents platfrom_util from invoking any shell or external APIs
+ // This prevents platform_util from invoking any shell or external APIs
// during tests. Doing so may result in external applications being launched
// and intefering with tests.
internal::DisableShellOperationsForTesting();
