| commit | 4fb6b66fb210d3566d17db851e72384d5478fe28 | [log] [tgz] |
|---|---|---|
| author | Samuel Groß <[email protected]> | Mon Nov 18 11:06:49 2024 |
| committer | Chromium LUCI CQ <[email protected]> | Mon Nov 18 11:06:49 2024 |
| tree | e21022f525a6657e825920f89c4405c6f5600045 | |
| parent | bb5873a8856cd234d1746ad5112e92ffa0ea8c24 [diff] [blame] |
Migrate to the new v8::String::Write* APIs In https://crrev.com/c/5975682 we introduced new versions of the v8::String::Write* APIs. This CL migrates the chromium uses of the old APIs to the new ones. Bug: 373485796, 376071292 Change-Id: I1905a9b65638c85580ea73b04edd8328f16fd683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6018204 Reviewed-by: Daniel Cheng <[email protected]> Commit-Queue: Samuel Groß <[email protected]> Cr-Commit-Position: refs/heads/main@{#1384241}
diff --git a/components/translate/content/renderer/translate_agent.cc b/components/translate/content/renderer/translate_agent.cc index d8e6da65..bee5bb61 100644 --- a/components/translate/content/renderer/translate_agent.cc +++ b/components/translate/content/renderer/translate_agent.cc
@@ -370,12 +370,13 @@ } v8::Local<v8::String> v8_str = result.As<v8::String>(); - int length = v8_str->Utf8Length(isolate); - if (length <= 0) + size_t length = v8_str->Utf8LengthV2(isolate); + if (length == 0) { return std::string(); + } - std::string str(static_cast<size_t>(length), '\0'); - v8_str->WriteUtf8(isolate, &str[0], length); + std::string str(length, '\0'); + v8_str->WriteUtf8V2(isolate, str.data(), length); return str; }