B4P cleanup, part 3: Delete Passwords Signin promo
This promo is not used anymore and so can be deleted.
This CL also deletes the related helper
ShouldShowChromeSignInPasswordPromo and deprecates the related prefs.
Bug: 1108738
Change-Id: Ifed0dd15adde95e1e233b8265274fea6463bfff5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3016005
Reviewed-by: Mohamed Amir Yosef <[email protected]>
Commit-Queue: Marc Treib <[email protected]>
Cr-Commit-Position: refs/heads/master@{#900390}
diff --git a/chrome/browser/prefs/browser_prefs.cc b/chrome/browser/prefs/browser_prefs.cc
index 084253e..0266019 100644
--- a/chrome/browser/prefs/browser_prefs.cc
+++ b/chrome/browser/prefs/browser_prefs.cc
@@ -123,7 +123,6 @@
#include "components/omnibox/browser/omnibox_prefs.h"
#include "components/omnibox/browser/zero_suggest_provider.h"
#include "components/optimization_guide/core/optimization_guide_prefs.h"
-#include "components/password_manager/core/browser/password_bubble_experiment.h"
#include "components/password_manager/core/browser/password_manager.h"
#include "components/payments/core/payment_prefs.h"
#include "components/policy/core/browser/browser_policy_connector.h"
@@ -621,6 +620,14 @@
const char kPasswordRecovery[] = "password_manager.password_recovery";
#endif
+// Deprecated 07/2021.
+const char kWasSignInPasswordPromoClicked[] =
+ "profile.was_sign_in_password_promo_clicked";
+const char kNumberSignInPasswordPromoShown[] =
+ "profile.number_sign_in_password_promo_shown";
+const char kSignInPasswordPromoRevive[] =
+ "profile.sign_in_password_promo_revive";
+
// Register local state used only for migration (clearing or moving to a new
// key).
void RegisterLocalStatePrefsForMigration(PrefRegistrySimple* registry) {
@@ -789,6 +796,10 @@
#if defined(OS_MAC)
registry->RegisterTimePref(kPasswordRecovery, base::Time());
#endif
+
+ registry->RegisterBooleanPref(kWasSignInPasswordPromoClicked, false);
+ registry->RegisterIntegerPref(kNumberSignInPasswordPromoShown, 0);
+ registry->RegisterBooleanPref(kSignInPasswordPromoRevive, false);
}
} // namespace
@@ -1056,7 +1067,6 @@
NotifierStateTracker::RegisterProfilePrefs(registry);
ntp_tiles::MostVisitedSites::RegisterProfilePrefs(registry);
optimization_guide::prefs::RegisterProfilePrefs(registry);
- password_bubble_experiment::RegisterPrefs(registry);
password_manager::PasswordManager::RegisterProfilePrefs(registry);
payments::RegisterProfilePrefs(registry);
PermissionBubbleMediaAccessHandler::RegisterProfilePrefs(registry);
@@ -1563,6 +1573,11 @@
profile_prefs->ClearPref(kPasswordRecovery);
#endif
+ // Added 07/2021
+ profile_prefs->ClearPref(kWasSignInPasswordPromoClicked);
+ profile_prefs->ClearPref(kNumberSignInPasswordPromoShown);
+ profile_prefs->ClearPref(kSignInPasswordPromoRevive);
+
// Please don't delete the following line. It is used by PRESUBMIT.py.
// END_MIGRATE_OBSOLETE_PROFILE_PREFS
}
