| commit | 401d25e97aaa37f9e029b71db0b9aec5847a7d93 | [log] [tgz] |
|---|---|---|
| author | Sean Maher <[email protected]> | Wed Dec 04 16:47:24 2024 |
| committer | Chromium LUCI CQ <[email protected]> | Wed Dec 04 16:47:24 2024 |
| tree | f0b85587a6a8bd2cc601116405937d9a0629b6bb | |
| parent | c0c96ee2790ebcd0a93e1c423e5fd74eb1808638 [diff] [blame] |
Reland "windows startup: OVERRIDE_PREFETCH_PARAMETER on singleton" This has been fixed by replacing DumpWithoutCrashing with a UMA histogram. Fixed: 381384992, 380088804 Bug: 325307453 Original change's description: > Revert "windows startup: OVERRIDE_PREFETCH_PARAMETER on acquiring singleton" > > This reverts commit 5693c9daaeb9ad34a00575195caf7f8a16342c35. > > Reason for revert: Broken GPU tests. 381384992 > > See three candidate CLs for fixes here: > - crrev.com/c/6055287 > - crrev.com/c/6055311 > - crrev.com/c/6056175 > > Original change's description: > > windows startup: OVERRIDE_PREFETCH_PARAMETER on acquiring singleton > > > > With this change, run a field trial to determine the impact of > > OVERRIDE_PREFETCH_PARAMETER on the acquiry of the singleton. > > > > This should effectively solve the case where short-lived browser > > processes are polluting the App Launch Prefetch history. Local tracing > > leads us to believe that recent versions of Windows implicitly support > > this but we decided to experiment with this newly discovered API > > nonetheless to verify how this fares in the wild. > > > > Bug: 325307453, 380088804 > > Change-Id: I515d983c6f558e4e896aadf4796b48487236f5b8 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5939457 > > Reviewed-by: Etienne Bergeron <[email protected]> > > Reviewed-by: Gabriel Charette <[email protected]> > > Reviewed-by: Greg Thompson <[email protected]> > > Commit-Queue: Sean Maher <[email protected]> > > Cr-Commit-Position: refs/heads/main@{#1389076} > > Bug: 325307453, 380088804 > Change-Id: I36945c81352bf4eae35d982c17db40bae0e8b2e5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6055288 > Owners-Override: Kenichi Ishibashi <[email protected]> > Bot-Commit: Rubber Stamper <[email protected]> > Reviewed-by: Kenichi Ishibashi <[email protected]> > Commit-Queue: Sean Maher <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1389655} Bug: 325307453, 380088804 Change-Id: I4d14ad4b59c34ba747d01f6d4c66a3018284673a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6059052 Reviewed-by: Greg Thompson <[email protected]> Reviewed-by: Sean Maher <[email protected]> Reviewed-by: Etienne Bergeron <[email protected]> Commit-Queue: Sean Maher <[email protected]> Cr-Commit-Position: refs/heads/main@{#1391721}
diff --git a/chrome/browser/chrome_process_singleton.h b/chrome/browser/chrome_process_singleton.h index 7567e5b9..dc79446 100644 --- a/chrome/browser/chrome_process_singleton.h +++ b/chrome/browser/chrome_process_singleton.h
@@ -48,6 +48,12 @@ bool IsSingletonInstanceForTesting() const { return is_singleton_instance_; } +#if BUILDFLAG(IS_WIN) + // Must only be called both after initialization of FeatureList and + // NotifyOtherProcessOrCreate(). + void InitializeFeatures(); +#endif + // Create the chrome process singleton instance for the current process. static void CreateInstance(const base::FilePath& user_data_dir); // Delete the chrome process singleton instance.