Enable VBR for RequestEncodingParametersChange
This CL makes the following conceptual change:
- Changes the VideoEncodeAccelerator::RequestEncodingParametersChange to
take a Bitrate, not uint32_t
This CL is the third CL in a series of CLs to enable VBR for accelerated
video encoding. This CL does not propagate these changes into ARC, and
no users are migrated to VBR encoding (functionality is unchanged).
Individual users will be updated to use VBR in separate follow-up CLs.
The design doc is available to @google.com users at go/vbr-vea.
Bug: b:181797390
Test: Ran Mojo unit tests; manually verified via VAAPI VBR prototype
Change-Id: I0f5274f97b0be10ae166e682f378e22896270a0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2987249
Commit-Queue: Clarissa Garvey <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Eugene Zemtsov <[email protected]>
Reviewed-by: Joe Downing <[email protected]>
Reviewed-by: Miguel Casas <[email protected]>
Reviewed-by: Hirokazu Honda <[email protected]>
Cr-Commit-Position: refs/heads/master@{#901343}
diff --git a/content/renderer/pepper/video_encoder_shim.h b/content/renderer/pepper/video_encoder_shim.h
index f802109..8e502822 100644
--- a/content/renderer/pepper/video_encoder_shim.h
+++ b/content/renderer/pepper/video_encoder_shim.h
@@ -13,6 +13,7 @@
#include "base/macros.h"
#include "base/memory/weak_ptr.h"
+#include "media/base/bitrate.h"
#include "media/video/video_encode_accelerator.h"
namespace base {
@@ -44,7 +45,7 @@
void Encode(scoped_refptr<media::VideoFrame> frame,
bool force_keyframe) override;
void UseOutputBitstreamBuffer(media::BitstreamBuffer buffer) override;
- void RequestEncodingParametersChange(uint32_t bitrate,
+ void RequestEncodingParametersChange(const media::Bitrate& bitrate,
uint32_t framerate) override;
void Destroy() override;
