chrome/browser: Migrate BASE_FEATURE macros to 2-argument version
This CL migrates three-argument BASE_FEATURE macros in //chrome/browser
to the new two-argument version where the C++ identifier and the string
feature name match.
This automated refactoring helps ensure that the C++ identifier and the
string feature name always match, reducing potential errors.
The following features could not be migrated automatically and may
require manual intervention:
* kFileSystemAccessPersistentPermissions vs "kFileSystemAccessPersistentPermissions"
* Name has k prefix.
* kExtensionTelemetryIncludePolicyData vs "SafeBrowsingExtensionTelemetryIncludePolicyData"
* Name has SafeBrowsing prefix.
* kOfferPinToTaskbarWhenSettingToDefault vs "OfferPinToTaskbarWhenSettingDefault"
* To vs When.
* kScrollableTabStripWithDragging vs "kScrollableTabStripWithDragging"
* Name has k prefix.
* kScrollableTabStripOverflow vs "kScrollableTabStripOverflow"
* Name has k prefix.
* kForceEnabled vs "WhatsNewForceEnabled"
* Name has WhatsNew prefix.
* kSkipDiscardsDrivenByStaleSignal vs "SkipDiscardDrivenByStaleSignal"
* Discards vs Discard.
* kAnnouncementNotification vs "AnnouncementNotificationService"
* Name has Service suffix.
* kDiyAppsDefaultCaptureForcedOff vs "capture_forced_off_diy_apps"
* Case and kebab-case mismatch.
* kNavigationCapturingOnExistingFrames vs "NavigationCapturingOnCurrentFrames"
* Existing vs Current.
* kIconDownloaderTimeout vs "WebAppIconDownloaderTimeout"
* Name has WebApp prefix.
* kAILanguageModelOverrideConfiguration vs "kAILanguageModelOverrideConfiguration"
* Name has k prefix.
* kAIModelUnloadableProgress vs "kAIModelUnloadableProgress"
* Name has k prefix.
* kReportKeyCredentialManagerSupportWinFeature vs "ReportKeyCredentialManagerSupportWin"
* Identifier has Feature suffix.
* kMetricsReportingFeature vs "MetricsReporting"
* Identifier has Feature suffix.
* kPostFREFixMetricsReportingFeature vs "PostFREFixMetricsReporting"
* Identifier has Feature suffix.
* kDsePreload2OnSuggestNonDefalutMatch vs "kDsePreload2OnSuggestNonDefalutMatch"
* Name has k prefix.
* kKcerWithoutNss vs "kKcerWithoutNss"
* Name has k prefix.
* kLauncherImageSearchDebug vs "kLauncherImageSearchDebug"
* Name has k prefix.
* kLauncherSearchFileScan vs "kLauncherSearchFileScan"
* Name has k prefix.
* kTopicsConsentDesktopModalFeature vs "TopicsConsentDesktopModal"
* Identifier has Feature suffix.
* kTopicsConsentModalClankBrAppFeature vs "TopicsConsentModalClankBrApp"
* Identifier has Feature suffix.
* kTopicsConsentModalClankCCTFeature vs "TopicsConsentModalClankCCT"
* Identifier has Feature suffix.
* kProtectedAudienceMeasurementNoticeModalFeature vs "ProtectedAudienceMeasurementNoticeModal"
* Identifier has Feature suffix.
* kProtectedAudienceMeasurementNoticeModalClankBrAppFeature vs "ProtectedAudienceMeasurementNoticeModalClankBrApp"
* Identifier has Feature suffix.
* kProtectedAudienceMeasurementNoticeModalClankCCTFeature vs "ProtectedAudienceMeasurementNoticeModalClankCCT"
* Identifier has Feature suffix.
* kThreeAdsAPIsNoticeModalFeature vs "ThreeAdsAPIsNoticeModal"
* Identifier has Feature suffix.
* kThreeAdsAPIsNoticeModalClankBrAppFeature vs "ThreeAdsAPIsNoticeModalClankBrApp"
* Identifier has Feature suffix.
* kThreeAdsAPIsNoticeModalClankCCTFeature vs "ThreeAdsAPIsNoticeModalClankCCT"
* Identifier has Feature suffix.
* kMeasurementNoticeModalFeature vs "MeasurementNoticeModal"
* Identifier has Feature suffix.
* kMeasurementNoticeModalClankBrAppFeature vs "MeasurementNoticeModalClankBrApp"
* Identifier has Feature suffix.
* kMeasurementNoticeModalClankCCTFeature vs "MeasurementNoticeModalClankCCT"
* Identifier has Feature suffix.
* kNoticeFrameworkTopicsApiFeature vs "PSNoticeFrameworkTopicsApi"
* Name has PS prefix.
* kNoticeFrameworkProtectedAudienceApiFeature vs "PSNoticeFrameworkProtectedAudienceApi"
* Name has PS prefix.
* kNoticeFrameworkMeasurementApiFeature vs "PSNoticeFrameworkMeasurementApi"
* Name has PS prefix.
* kTranslateStreamingBySentence vs "kTranslateStreamingBySentence"
* Name has k prefix.
* kAndroidTabSkipSaveTabsKillswitch vs "AndroidTabSkipSaveTabsTaskKillswitch"
* Name has Task prefix.
* kAndroidXRUsesSurfaceControl vs "AndroidWindowPopupResizeAfterSpawn"
* Identifier has different name.
* kAndroidSearchInSettings vs "SearchInSettings"
* Identifier has Android prefix.
* kUmaBackgroundSessions vs "UMABackgroundSessions"
* Case difference.
* kCastAllowAllIPsFeature vs "CastAllowAllIPs"
* Identifier has Feature suffix.
* kOidcEnrollmentTimeout vs "kOidcEnrollmentTimeout"
* Name has k prefix.
* kEnableOidcProfileRemoteCommands vs "kEnableOidcProfileRemoteCommands"
* Name has k prefix.
Enabled-by-default-reason: refactor
NO_IFTTT=refactor, no functionality change
Bug: 436274260
Change-Id: Ie1e197db899530edefc2d00ea0a8e2b4ceea85f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6943827
Reviewed-by: Daniel Cheng <[email protected]>
Auto-Submit: Xiaohan Wang <[email protected]>
Commit-Queue: Daniel Cheng <[email protected]>
Owners-Override: Daniel Cheng <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1515263}
diff --git a/chrome/browser/contextmenu/context_menu_features.cc b/chrome/browser/contextmenu/context_menu_features.cc
index 59b5d5d..30ec7e4 100644
--- a/chrome/browser/contextmenu/context_menu_features.cc
+++ b/chrome/browser/contextmenu/context_menu_features.cc
@@ -8,9 +8,7 @@
// Enables the empty space context menu on Clank.
#if BUILDFLAG(IS_ANDROID)
-BASE_FEATURE(kContextMenuEmptySpace,
- "ContextMenuEmptySpace",
- base::FEATURE_ENABLED_BY_DEFAULT);
+BASE_FEATURE(kContextMenuEmptySpace, base::FEATURE_ENABLED_BY_DEFAULT);
#endif // BUILDFLAG(IS_ANDROID)
} // namespace features
