jumboify base
Requires teaching the jumbo scripts about .S files.
Also fix some minor formatting issues in the jumbo docs.
On my Mac laptop, for release component builds:
* increases by 536% (from 3.3s to 21s) incremental build times
of 'base', after touching base/strings/string16.cc.
* reduces by 65% (from 91s to 32s) full build times of 'base'
So this looks like something that's useful for full builds and
for playing with compiler flags (which requires full builds),
but probably not something for daily development. I suppose
that's true of jumbo builds in general.
Bug: 775547
Change-Id: I9b5157682ee463e5d60499f4dc8815283a127729
Reviewed-on: https://chromium-review.googlesource.com/721139
Commit-Queue: Nico Weber <[email protected]>
Reviewed-by: Dirk Pranke <[email protected]>
Reviewed-by: oysteine <[email protected]>
Cr-Commit-Position: refs/heads/master@{#509524}diff --git a/base/sync_socket_win.cc b/base/sync_socket_win.cc
index 797f12f..3c132400 100644
--- a/base/sync_socket_win.cc
+++ b/base/sync_socket_win.cc
@@ -253,8 +253,8 @@
while (count < length) {
DWORD len;
DWORD chunk = GetNextChunkSize(count, length);
- if (WriteFile(handle_, static_cast<const char*>(buffer) + count,
- chunk, &len, NULL) == FALSE) {
+ if (::WriteFile(handle_, static_cast<const char*>(buffer) + count, chunk,
+ &len, NULL) == FALSE) {
return count;
}
count += len;
@@ -278,8 +278,8 @@
while (count < length) {
DWORD len;
DWORD chunk = GetNextChunkSize(count, length);
- if (ReadFile(handle_, static_cast<char*>(buffer) + count,
- chunk, &len, NULL) == FALSE) {
+ if (::ReadFile(handle_, static_cast<char*>(buffer) + count, chunk, &len,
+ NULL) == FALSE) {
return count;
}
count += len;
@@ -328,23 +328,23 @@
size_t CancelableSyncSocket::Send(const void* buffer, size_t length) {
static const DWORD kWaitTimeOutInMs = 500;
return CancelableFileOperation(
- &WriteFile, handle_, reinterpret_cast<const char*>(buffer),
- length, &file_operation_, &shutdown_event_, this, kWaitTimeOutInMs);
+ &::WriteFile, handle_, reinterpret_cast<const char*>(buffer), length,
+ &file_operation_, &shutdown_event_, this, kWaitTimeOutInMs);
}
size_t CancelableSyncSocket::Receive(void* buffer, size_t length) {
return CancelableFileOperation(
- &ReadFile, handle_, reinterpret_cast<char*>(buffer), length,
+ &::ReadFile, handle_, reinterpret_cast<char*>(buffer), length,
&file_operation_, &shutdown_event_, this, INFINITE);
}
size_t CancelableSyncSocket::ReceiveWithTimeout(void* buffer,
size_t length,
TimeDelta timeout) {
- return CancelableFileOperation(
- &ReadFile, handle_, reinterpret_cast<char*>(buffer), length,
- &file_operation_, &shutdown_event_, this,
- static_cast<DWORD>(timeout.InMilliseconds()));
+ return CancelableFileOperation(&::ReadFile, handle_,
+ reinterpret_cast<char*>(buffer), length,
+ &file_operation_, &shutdown_event_, this,
+ static_cast<DWORD>(timeout.InMilliseconds()));
}
// static
