| commit | 088fb77a7ca1059a3430e5eb48f8a3e6c515173b | [log] [tgz] |
|---|---|---|
| author | Mehran Mahmoudi <[email protected]> | Tue May 14 21:58:31 2019 |
| committer | Commit Bot <[email protected]> | Tue May 14 21:58:31 2019 |
| tree | a4daafd546034303377008802d0a69e566afbef7 | |
| parent | b6724743f2c2f9b98cead8b840b78af97c559b92 [diff] [blame] |
[Touchless] Support permission dialogs in touchless This CL ports existing permission dialogs to use TouchlessDialogPresenter when in touchless mode. Since permission dialogs in touchless mode have titles that describe the type of permission, this CL also adds the new GetTypeText() to the PermissionRequest class. Link to UX deck: https://docs.google.com/presentation/d/1c-aVSZ_zsBuzCwQ4CrBJppmRQjiupa6PXmlC2OS-F-Q/edit#slide=id.g4fb0666bdb_2_5 Bug: 959204 Change-Id: I749dcfe28b7d5264947325e0d72f62f5ca300c96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606564 Commit-Queue: Mehran Mahmoudi <[email protected]> Reviewed-by: Ted Choc <[email protected]> Reviewed-by: Matthew Jones <[email protected]> Reviewed-by: Dominick Ng <[email protected]> Cr-Commit-Position: refs/heads/master@{#659677}
diff --git a/chrome/browser/permissions/permission_request.h b/chrome/browser/permissions/permission_request.h index 61522a7..5aeadb2 100644 --- a/chrome/browser/permissions/permission_request.h +++ b/chrome/browser/permissions/permission_request.h
@@ -85,6 +85,10 @@ virtual IconId GetIconId() const = 0; #if defined(OS_ANDROID) + // Returns the title of this permission as text. This is currently only used + // in touchless mode in Android. + virtual base::string16 GetTitleText() const = 0; + // Returns the full prompt text for this permission. This is currently only // used on Android. virtual base::string16 GetMessageText() const = 0;