Add blink_platform_unittests filter for android-nougat-x86-rel.
Filtered tests include:
-HarfBuzzShaperTest.IdeographicSpace
-HarfBuzzShaperTest.ShapeHorizontalWithSubpixelPositionWithoutKerningIsNotRounded
-HarfBuzzShaperTest.ShapeHorizontalWithoutSubpixelPositionWithKerningIsRounded
The next CL is to add this filter to the corresponding testing target:
http://crrev/c/3730598.
Bug: 1303439, 1254869, 1108121
Change-Id: Ic690268b46b8a585df88adf46a202add7894ab35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3726858
Reviewed-by: Ben Pastene <[email protected]>
Reviewed-by: Benjamin Joyce <[email protected]>
Commit-Queue: James Shen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1018501}
diff --git a/testing/buildbot/chromium.android.fyi.json b/testing/buildbot/chromium.android.fyi.json
index 4dd2908..2640df9 100644
--- a/testing/buildbot/chromium.android.fyi.json
+++ b/testing/buildbot/chromium.android.fyi.json
@@ -2889,7 +2889,8 @@
"args": [
"--gs-results-bucket=chromium-result-details",
"--recover-devices",
- "--avd-config=../../tools/android/avd/proto/generic_android24.textpb"
+ "--avd-config=../../tools/android/avd/proto/generic_android24.textpb",
+ "--test-launcher-filter-file=../../testing/buildbot/filters/android.emulator_n.blink_platform_unittests.filter"
],
"isolate_profile_data": true,
"merge": {
diff --git a/testing/buildbot/filters/BUILD.gn b/testing/buildbot/filters/BUILD.gn
index f6c44f55..b852a54 100644
--- a/testing/buildbot/filters/BUILD.gn
+++ b/testing/buildbot/filters/BUILD.gn
@@ -36,6 +36,12 @@
]
}
+source_set("blink_platform_unittests") {
+ testonly = true
+
+ data = [ "//testing/buildbot/filters/android.emulator_n.blink_platform_unittests.filter" ]
+}
+
source_set("blink_unittests_filters") {
testonly = true
diff --git a/testing/buildbot/filters/android.emulator_n.blink_platform_unittests.filter b/testing/buildbot/filters/android.emulator_n.blink_platform_unittests.filter
new file mode 100644
index 0000000..da67c4f
--- /dev/null
+++ b/testing/buildbot/filters/android.emulator_n.blink_platform_unittests.filter
@@ -0,0 +1,6 @@
+# https://crbug.com/1254869
+-HarfBuzzShaperTest.IdeographicSpace
+
+# https://crbug.com/1108121
+-HarfBuzzShaperTest.ShapeHorizontalWithSubpixelPositionWithoutKerningIsNotRounded
+-HarfBuzzShaperTest.ShapeHorizontalWithoutSubpixelPositionWithKerningIsRounded
\ No newline at end of file
diff --git a/testing/buildbot/test_suite_exceptions.pyl b/testing/buildbot/test_suite_exceptions.pyl
index e852705..536ae16 100644
--- a/testing/buildbot/test_suite_exceptions.pyl
+++ b/testing/buildbot/test_suite_exceptions.pyl
@@ -205,6 +205,12 @@
},
'blink_platform_unittests': {
'modifications': {
+ # TODO(crbug.com/1303439): Remove this filter
+ 'android-nougat-x86-rel': {
+ 'args': [
+ '--test-launcher-filter-file=../../testing/buildbot/filters/android.emulator_n.blink_platform_unittests.filter',
+ ],
+ },
'android-pie-arm64-rel': {
# TODO(crbug.com/1111436): Move this back to walleye if/when additional
# capacity has been deployed.
