[webauthn] Have GPM link open password detail page
When saving, updating, or deleting a Google Password Manager passkey, a
bubble shows up with a link to the Google Password Manager. This CL
makes it so that when the user taps that bubble, they are sent to the
details page for that site instead of the general page.
For passkeys that have been deleted, that means sometimes GPM won't have
any information for that site. That's fine, in that case, the user will
be immediately redirected to the main GPM page.
Bug: 361751877
Change-Id: Iae11d38208cb27c8141f4b2dd0b905d3b0a1a981
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5954664
Reviewed-by: Mohamed Amir Yosef <[email protected]>
Commit-Queue: Ken Buchanan <[email protected]>
Auto-Submit: Nina Satragno <[email protected]>
Reviewed-by: Ken Buchanan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1372397}
diff --git a/chrome/browser/ui/webauthn/passkey_updated_confirmation_controller.cc b/chrome/browser/ui/webauthn/passkey_updated_confirmation_controller.cc
index 95ba9bc..e3d3a23 100644
--- a/chrome/browser/ui/webauthn/passkey_updated_confirmation_controller.cc
+++ b/chrome/browser/ui/webauthn/passkey_updated_confirmation_controller.cc
@@ -11,8 +11,10 @@
PasskeyUpdatedConfirmationController::PasskeyUpdatedConfirmationController(
base::WeakPtr<PasswordsModelDelegate> delegate,
- password_manager::metrics_util::UIDisplayDisposition display_disposition)
- : PasswordBubbleControllerBase(std::move(delegate), display_disposition) {}
+ password_manager::metrics_util::UIDisplayDisposition display_disposition,
+ std::string passkey_rp_id)
+ : PasswordBubbleControllerBase(std::move(delegate), display_disposition),
+ passkey_rp_id_(std::move(passkey_rp_id)) {}
PasskeyUpdatedConfirmationController::~PasskeyUpdatedConfirmationController() {
OnBubbleClosing();
@@ -26,9 +28,9 @@
OnGooglePasswordManagerLinkClicked() {
dismissal_reason_ = password_manager::metrics_util::CLICKED_MANAGE;
if (delegate_) {
- delegate_->NavigateToPasswordManagerSettingsPage(
- password_manager::ManagePasswordsReferrer::
- kPasskeyUpdatedConfirmationBubble);
+ delegate_->NavigateToPasswordDetailsPageInPasswordManager(
+ passkey_rp_id_, password_manager::ManagePasswordsReferrer::
+ kPasskeyUpdatedConfirmationBubble);
}
}
