| commit | 01ab59ae08a38a361da7dac41e36f387f6600ed5 | [log] [tgz] |
|---|---|---|
| author | Peter Boström <[email protected]> | Thu Aug 15 02:39:49 2024 |
| committer | Chromium LUCI CQ <[email protected]> | Thu Aug 15 02:39:49 2024 |
| tree | 367f6021e14271e642cf993ecde520a4270d500c | |
| parent | cc7de172793f56284aa58a1a9ac8d75f1a853b5a [diff] [blame] |
Migrate NOTREACHED_NORETURN -> NOTREACHED
NOTREACHED() has turned [[noreturn]] so the former macro isn't needed
anymore.
This does not attempt to do a rewrite of any surrounding code, like:
if (!foo) {
NOTREACHED();
}
to CHECK(foo);
Those transforms take a non-trivial amount of time (and there are
thousands of instances). Cleanup can be left as an exercise for the
reader.
NO_IFTTT=No-op-rename migration.
Bug: 40580068
Change-Id: I068c5fdce9dc4c352d8bdd62bb3cd2c0a2d59659
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5782602
Reviewed-by: Daniel Cheng <[email protected]>
Owners-Override: Daniel Cheng <[email protected]>
Commit-Queue: Daniel Cheng <[email protected]>
Commit-Queue: Peter Boström <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1342096}
diff --git a/chrome/browser/usb/usb_system_tray_icon.cc b/chrome/browser/usb/usb_system_tray_icon.cc index 6ef25c4..588b088 100644 --- a/chrome/browser/usb/usb_system_tray_icon.cc +++ b/chrome/browser/usb/usb_system_tray_icon.cc
@@ -27,7 +27,7 @@ return l10n_util::GetPluralStringFUTF16(IDS_WEBUSB_SYSTEM_TRAY_ICON_TITLE, static_cast<int>(num_connections)); #else - NOTREACHED_NORETURN(); + NOTREACHED(); #endif // BUILDFLAG(ENABLE_EXTENSIONS) }