Google Git
Sign in
chromium / chromium / src.git / 003b56ea646dd2f4c0d604f03eae532c52ec2f81
commit003b56ea646dd2f4c0d604f03eae532c52ec2f81[log] [tgz]
authorLei Zhang <[email protected]>Thu Feb 20 20:43:12 2025
committerChromium LUCI CQ <[email protected]>Thu Feb 20 20:43:12 2025
tree9c28724af493cddbe39b5cb1aaf6771325745d8a
parent3ea9a63ba1243de0c4e08f0e38884bb8da2351e4 [diff]
[PDF Ink Signatures] Deactivate Ink strokes before rendering thumbnails

For PDF thumbnails, PDFiumEngine::RequestThumbnail() should be drawing
the original thumbnail, without any Ink strokes.
PdfInkModule::DrawThumbnail() separately draws the Ink strokes as
another layer on top of the original thumbnail. With the work in
https://crbug.com/335517469, now the PDF loaded in PDFiumEngine contains
Ink strokes, so refreshing PDF thumbnails will end up rendering the Ink
strokes twice. Fix this by temporarily deactivating the page objects
associated with Ink strokes for a given page when generating the
thumbnail for that page.

Bug: 395766076
Change-Id: I565df2f21b3fae8cf6ebe4df44149f3709fe149a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6271523
Commit-Queue: Lei Zhang <[email protected]>
Reviewed-by: Alan Screen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1422737}
3 files changed
tree: 9c28724af493cddbe39b5cb1aaf6771325745d8a
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.