Page MenuHomePhabricator

WIP: Bug 1870880 - Add isInstance assertion method to Assert.sys.mjs
Changes PlannedPublic

Authored by gravyant on Apr 11 2024, 4:07 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sep 14 2025, 11:22 PM
Unknown Object (File)
Sep 14 2025, 8:38 PM
Unknown Object (File)
Sep 12 2025, 2:08 AM
Unknown Object (File)
May 29 2025, 9:10 AM
Unknown Object (File)
May 5 2025, 6:39 AM
Unknown Object (File)
Feb 4 2025, 1:15 AM
Unknown Object (File)
Dec 22 2024, 12:21 PM
Unknown Object (File)
Sep 20 2024, 9:55 AM
Subscribers

Details

Reviewers
None
Group Reviewers
webdriver-reviewers
Bugzilla Bug ID
1870880

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Branch
default

Event Timeline

gravyant created this revision.
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Apr 11 2024, 4:07 AM
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.

Am I on the right track with the function signature and implementation?

I know the method should be used only for classes with the isInstance method implemented, so should I check for the constructor having that method/property in the function body?

gravyant updated this revision to Diff 848507.

Am I on the right track with the function signature and implementation?

Yes, looks close :)

I know the method should be used only for classes with the isInstance method implemented, so should I check for the constructor having that method/property in the function body?

Yes, you have to add the check for the isInstance method.

Regarding the testing, it would be good in this case to add a xpcshell test here: https://searchfox.org/mozilla-central/source/remote/shared/webdriver/test/xpcshell/test_Assert.js