python-openstackclient

v3 endpoint related commands access service.name without check

Bug #1406737 reported by Zhiyuan Cai
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-openstackclient
Fix Released
Undecided
Zhiyuan Cai
python-openstackclient m7 "nitrogen"

Bug Description

Currently v3 endpoint create, list and show commands access Service object's name attribute directly without check. However, name is not a required attribute of Service object. So if we create a service without name and create an endpoint with that service, using v3 command, we will get an AttributeError when executing v3 endpoint list and show commands later.

Zhiyuan Cai (luckyvega-g)
Changed in python-openstackclient:
assignee: nobody → Zhiyuan Cai (luckyvega-g)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-openstackclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/144857

Changed in python-openstackclient:
status: New → In Progress
Revision history for this message
Lin Hua Cheng (lin-hua-cheng) wrote :

Maybe fixed with this patch: https://review.openstack.org/#/c/135808/

Dean Troyer (dtroyer)
Changed in python-openstackclient:
milestone: none → m7
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-openstackclient (master)

Reviewed: https://review.openstack.org/144857
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=369ae3f9f06c90e8d57b71befa6bc22a843c2f7d
Submitter: Jenkins
Branch: master

commit 369ae3f9f06c90e8d57b71befa6bc22a843c2f7d
Author: zhiyuan_cai <email address hidden>
Date: Sun Jan 4 11:26:18 2015 +0800

    Check if service.name available before access

    Currently v3 endpoint commands access service.name directly, while
    name is not a required attribute of service. So if we associate an
    endpoint to a service without name, we will get an AttributeError
    executing v3 endpoint commands later. This patch addresses this
    issue by checking if service.name is available before accessing it.

    Change-Id: I3dd686ef02a2e21e2049a49cb55634385c2ecfaf
    Closes-Bug: #1406737

Changed in python-openstackclient:
status: In Progress → Fix Committed
Dean Troyer (dtroyer)
Changed in python-openstackclient:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.