Cinder

XtremeIO driver does not honor clone volume size

Bug #1554778 reported by Sean McGinnis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Medium
Xinli Guan
Cinder ongoing

Bug Description

It's possible to create a volume from a source volume with a different size. The create_cloned_volume call into the driver could have a larger volume['size'] than the source volume. So the driver will need to create the clone, then check if it needs to extend the volume to a new size.

Xing Yang (xing-yang)
Changed in cinder:
assignee: nobody → Shay Halsband (shay-halsband)
importance: Undecided → Medium
status: New → Triaged
Sean McGinnis (sean-mcginnis)
Changed in cinder:
milestone: none → newton-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/292432

Changed in cinder:
status: Triaged → In Progress
Sean McGinnis (sean-mcginnis)
Changed in cinder:
milestone: newton-1 → newton-2
OpenStack Infra (hudson-openstack)
Changed in cinder:
assignee: Shay Halsband (shay-halsband) → Erlon R. Cruz (sombrafam)
OpenStack Infra (hudson-openstack)
Changed in cinder:
assignee: Erlon R. Cruz (sombrafam) → Shay Halsband (shay-halsband)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cinder (master)

Change abandoned by Shay Halsband (<email address hidden>) on branch: master
Review: https://review.openstack.org/292432
Reason: has a generic fix in the manager

OpenStack Infra (hudson-openstack)
Changed in cinder:
assignee: Shay Halsband (shay-halsband) → Erlon R. Cruz (sombrafam)
Sean McGinnis (sean-mcginnis)
Changed in cinder:
milestone: newton-2 → ocata-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Sean McGinnis (<email address hidden>) on branch: master
Review: https://review.openstack.org/336092
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Sean McGinnis (sean-mcginnis)
Changed in cinder:
milestone: ocata-1 → ongoing
OpenStack Infra (hudson-openstack)
Changed in cinder:
assignee: Erlon R. Cruz (sombrafam) → Xinli Guan (xinli-v)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/292432
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=105e625328a3ead1fb9b788e54e81a9b5d9af5ab
Submitter: Jenkins
Branch: master

commit 105e625328a3ead1fb9b788e54e81a9b5d9af5ab
Author: Shay Halsband <email address hidden>
Date: Sun Mar 13 16:56:30 2016 +0200

    XtremIO: allow a cloned volume with larger size

    * In case the new volume is larger than the cloned one,
        resize the cloned volume.
    * Added unit test for success and failed resize.

    Co-Authored-By: Xinli Guan <email address hidden>

    Change-Id: I2346049c2177a9497750c05c0eb9e7edf8c12c22
    Closes-Bug: #1554778

Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/447421

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/ocata)

Reviewed: https://review.openstack.org/447421
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=04c7e6a2a56c5f6e9d3e7f0d3c9769b12182d65a
Submitter: Jenkins
Branch: stable/ocata

commit 04c7e6a2a56c5f6e9d3e7f0d3c9769b12182d65a
Author: Shay Halsband <email address hidden>
Date: Sun Mar 13 16:56:30 2016 +0200

    XtremIO: allow a cloned volume with larger size

    * In case the new volume is larger than the cloned one,
        resize the cloned volume.
    * Added unit test for success and failed resize.

    Co-Authored-By: Xinli Guan <email address hidden>

    Change-Id: I2346049c2177a9497750c05c0eb9e7edf8c12c22
    Closes-Bug: #1554778
    (cherry picked from commit 105e625328a3ead1fb9b788e54e81a9b5d9af5ab)

tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (driverfixes/mitaka)

Fix proposed to branch: driverfixes/mitaka
Review: https://review.openstack.org/453950

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/454689

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/newton)

Reviewed: https://review.openstack.org/454689
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=908def6bb993798146cccc1621a9cee18950629d
Submitter: Jenkins
Branch: stable/newton

commit 908def6bb993798146cccc1621a9cee18950629d
Author: Shay Halsband <email address hidden>
Date: Sun Mar 13 16:56:30 2016 +0200

    XtremIO: allow a cloned volume with larger size

    * In case the new volume is larger than the cloned one,
        resize the cloned volume.
    * Added unit test for success and failed resize.

    Co-Authored-By: Xinli Guan <email address hidden>

    Change-Id: I2346049c2177a9497750c05c0eb9e7edf8c12c22
    Closes-Bug: #1554778
    (cherry picked from commit 105e625328a3ead1fb9b788e54e81a9b5d9af5ab)

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 11.0.0.0b1

This issue was fixed in the openstack/cinder 11.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 9.1.4

This issue was fixed in the openstack/cinder 9.1.4 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (driverfixes/mitaka)

Reviewed: https://review.openstack.org/453950
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=9e2099e660fd2fa621e455b1e29a27b712e52b44
Submitter: Jenkins
Branch: driverfixes/mitaka

commit 9e2099e660fd2fa621e455b1e29a27b712e52b44
Author: Shay Halsband <email address hidden>
Date: Sun Mar 13 16:56:30 2016 +0200

    XtremIO: allow a cloned volume with larger size

    * In case the new volume is larger than the cloned one,
        resize the cloned volume.
    * Added unit test for success and failed resize.

    Conflicts:
            cinder/tests/unit/volume/drivers/dell_emc/test_xtremio.py

    Co-Authored-By: Xinli Guan <email address hidden>

    Change-Id: I2346049c2177a9497750c05c0eb9e7edf8c12c22
    Closes-Bug: #1554778
    (cherry picked from commit 105e625328a3ead1fb9b788e54e81a9b5d9af5ab)

tags: added: in-driverfixes-mitaka
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 10.0.2

This issue was fixed in the openstack/cinder 10.0.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cinder (master)

Change abandoned by Jay Bryant (<email address hidden>) on branch: master
Review: https://review.openstack.org/336092
Reason: It was decided that we wouldn't go down this path so we this patch can be abandoned.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.