Impossible to end a call after switching to airplane mode

Version: ubuntu-touch/stable/bq-aquaris.en r21 krillin

Confirmed - the dial carries on as if the call hasn't ended (duration continues increasing).

Looks like dialer does realise call has been pulled from under it.

/usr/share/ofono/scripts/list-calls shows nothing active.

The modem goes to flight mode (online = 0), but never changes the state of the calls to "disconnected". Not sure what's the expected behavior here in ofono, but I belive ofono should set the State to "disconnected" and DisconnectReason to "network" in such case.

We could also force terminate the calls in tp-ofono when the modem goes offline as well.

I have been testing this, and it is racy: in some cases ofono drops the call (no output from list-calls) and in other cases it does not (list-calls shows calls even after with flight mode set). It depends on the order in which urfkill switches off the slots.

This PR fixes the issue on the ofono side:

https://github.com/rilmodem/ofono/pull/177

However, there is still some problem in telepathy/dialler even with the patched ofono. Doing:

1. Start call from dialler
2. Set flight mode (call is dropped)
3. Unset flight mode
4. Start a second call from dialler
5. Set flight mode (call is dropped)
6. Unset flight mode
7. I cannot start call from dialler: pressing the dial button does nothing.

I have checked that the disconnect events for the previous calls are generated and that I can start a call from the command line (activate-call).

I marked the dialer(app) task as Incomplete, as I'm not sure it requires a change.

I also added an indicator-network task as it's not clear the indicator should allow flight-mode to be enabled when an active call exists. This should absolutely be prevented during an emergency call, but I would argue that it should be prevented during any active calls.

I'm not sure if there's a separate Unity/framework mechanism which would prevent "ear-induced-flight-mode", but maybe this could be accomplished via the proximity sensor as an alternative ( only if foolproof ).

I agree that the 'flight mode' switch should be somehow disabled during active call, but I would not dismiss completely the need to fix the dialer app. I have no idea how exactly the communication between dialer and modem is organized, but I can imagine some other methods to fall into this bug - like accidentally removing sim card (for example by dropping the phone), or by losing gsm connection. The dialer app should be prepared for such cases.

While testing the ofono landing that drops the call, I have seen many problems with dialler/telephony service after calling/setting FM/unsetting FM. If I do not re-start the dialler app, audio is not working when pressing buttons. I can dial, but I cannot drop the call (from the app, the ofono script works), and some random failures (see comment #5 too). I will add a telephony-service task.

Until it lands, the patched ofono is in silo 27:

https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/landing-027

in case somebody wants to use it for debugging dialler/telephony-service.

The Phone app does need to handle cases that software can't, like ejecting the SIM or going out of range. But entering Flight Mode is something you do interactively, so likely mistakes should be handled interactively. And this exact case has been in the "Flight Mode" section of the Networking spec since April 2014. <https://wiki.ubuntu.com/Networking?action=diff&rev2=165&rev1=164>

(If the design is inappropriate, then let's change it, but that doesn't seem to be the issue here. If there's anything I can do to make it easier or more fun for engineers to ask "I wonder what the spec says about this?", please let me know.)

I just experienced the same with image r22, 20150508 on the bq ubuntu phone.

In the middle of a phone call, where I was holding the phone to my ear (so interaction should be blocked), the phone call finished (I could not hear the person at the other end of the line speaking any more), but pushing the hang-up button did not do anything.

I rebooted the phone, and both sim cards were not detected and then I saw that flight mode was on. After switching off flight mode I needed another reboot to get it to work again.

So there are two issues here:
1. Interaction was not blocked while I was in a phone call
2. Dialer app does not detect that flight mode gets enabled and the sim card is disabled.

Since then I have been trying to see if the proximity sensor works properly while in a phone call. Once I managed to push the hang-up button while the phone was on my ear (I couldn't see if the screen was on or off). But afterwards I have been testing and the proximity sensor seems fine now, the screen turns off and does not respond to touch when I hold my finger (or ear) close to the camera.

So issue 2 of my previous comment is what is being tracked in this bug. For issue 1, I reported a new bug: https://bugs.launchpad.net/ubuntu/+source/telepathy-ofono/+bug/1454845