JDK-8238249 : GetPrimitiveArrayCritical passed with hardcoded FALSE value
  • Type: Bug
  • Component: javafx
  • Sub-Component: graphics
  • Affected Version: jfx11,8
  • Priority: P3
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2020-01-30
  • Updated: 2020-06-22
  • Resolved: 2020-01-30
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 8 Other
8u261Fixed jfx11.0.8Fixed
Related Reports
Blocks :  
JDK-8212034 - Potential memory leaks in jpegLoader.c in error case
Description
The following call to GetPrimitiveArrayCritical in jpegloader.c is misleading:

           jboolean iscopy = FALSE;
            jbyte *body = (*env)->GetPrimitiveArrayCritical(env, barray, &iscopy);

It looks like we want to pass "FALSE" to the isCopy parameter of GetPrimitiveArrayCritical, while this field is actually set by the VM when it informs the caller whether a copy is made or not. The jscopy parameter is not used outside this scope.
Comments
Changeset: ca37c1fb Author: Johan Vos <[email protected]> Date: 2020-01-30 20:59:54 +0000 URL: https://git.openjdk.java.net/jfx/commit/ca37c1fb
30-01-2020
I set the fixversion to "tbd" as a test to see whether the Skara tooling will set it to the right version when integrated. If they've set it up properly, it will change it from "tbd" to "openjfx15" when integrated.
30-01-2020