Changeset 454

Timestamp:

Jun 4, 2010, 3:11:43 PM (16 years ago)

Author:

Silvan Scherrer

Message:

Samba Server 3.5: merged changes from 3.3

Location:

trunk/server/source3

Files:

• Makefile.in (modified) (8 diffs)
• build.cmd (added)
• build.options (added)
• dynconfig.c (modified) (3 diffs)
• groupdb/mapping_ldb.c (modified) (1 diff)
• include/g_lock.h (added)
• include/version.h (modified) (1 diff)
• lib/charcnv.c (modified) (1 diff)
• lib/fault.c (modified) (4 diffs)
• lib/g_lock.c (added)
• lib/iconv.c (modified) (4 diffs)
• lib/ldb/common/ldb.c (modified) (1 diff)
• lib/ldb/ldb_tdb/ldb_tdb.c (modified) (1 diff)
• lib/os2ea.c (added)
• lib/os2path.c (added)
• lib/pidfile.c (modified) (4 diffs)
• lib/readline.c (modified) (1 diff)
• lib/select.c (modified) (1 diff)
• lib/smbrun.c (modified) (2 diffs)
• lib/system.c (modified) (13 diffs)
• lib/system_smbd.c (modified) (2 diffs)
• lib/util.c (modified) (1 diff)
• lib/util_sec.c (modified) (4 diffs)
• lib/util_sock.c (modified) (3 diffs)
• lib/util_str.c (modified) (1 diff)
• libaddns/dns.h (modified) (1 diff)
• libaddns/dnserr.h (modified) (1 diff)
• libsmb/clientgen.c (modified) (2 diffs)
• libsmb/clifile.c (modified) (2 diffs)
• locking/posix.c (modified) (2 diffs)
• nmbd/asyncdns.c (modified) (1 diff)
• nmbd/nmbd.c (modified) (3 diffs)
• nmbd/nmbd_serverlistdb.c (modified) (2 diffs)
• nmbd/nmbd_winsserver.c (modified) (1 diff)
• param/loadparm.c (modified) (2 diffs)
• passdb/pdb_smbpasswd.c (modified) (6 diffs)
• printing/printing.c (modified) (1 diff)
• rpc_server/srv_srvsvc_nt.c (modified) (6 diffs)
• smbd/dosmode.c (modified) (3 diffs)
• smbd/password.c (modified) (1 diff)
• smbd/reply.c (modified) (2 diffs)
• smbd/server.c (modified) (1 diff)
• smbd/service.c (modified) (2 diffs)
• smbd/sesssetup.c (modified) (1 diff)
• smbd/trans2.c (modified) (5 diffs)
• smbd/vfs.c (modified) (2 diffs)
• torture/torture.c (modified) (2 diffs)
• utils/net_g_lock.c (added)
• utils/net_usershare.c (modified) (2 diffs)
• utils/net_util.c (modified) (1 diff)
• version.ec_ (added)
• web/cgi.c (modified) (2 diffs)
• web/startstop.c (modified) (10 diffs)
• web/swat.c (modified) (1 diff)

trunk/server/source3/Makefile.in

@@ -391 +391 @@
           $(VERSION_OBJ) lib/charcnv.o lib/debug.o lib/fault.o \
           lib/interface.o lib/pidfile.o \
-          lib/system.o lib/sendfile.o lib/recvfile.o lib/time.o \
+          lib/system.o lib/sendfile.o lib/recvfile.o lib/time.o \
           lib/username.o \
           ../libds/common/flag_mapping.o \
@@ -1785 +1785 @@
                 $(LIBTALLOC_LIBS) $(LIBTDB_LIBS) $(ZLIB_LIBS)
 
-bin/ldbedit: $(BINARY_PREREQS) $(LDBEDIT_OBJ) @BUILD_POPT@ $(LIBTALLOC) $(LIBTDB) $(LIBWBCLIENT)
+bin/ldbedit: $(BINARY_PREREQS) $(LDBEDIT_OBJ) @BUILD_POPT@ $(LIBTALLOC) $(LIBTDB) $(LIBWBCLIENT)
         @echo Linking $@
         @$(CC) -o $@ $(LDBEDIT_OBJ) $(DYNEXP) $(LDFLAGS) \
@@ -1791 +1791 @@
                 $(LIBTALLOC_LIBS) $(LIBTDB_LIBS)
 
-bin/ldbsearch: $(BINARY_PREREQS) $(LDBSEARCH_OBJ) @BUILD_POPT@ $(LIBTALLOC) $(LIBTDB) $(LIBWBCLIENT)
+bin/ldbsearch: $(BINARY_PREREQS) $(LDBSEARCH_OBJ) @BUILD_POPT@ $(LIBTALLOC) $(LIBTDB) $(LIBWBCLIENT)
         @echo Linking $@
         @$(CC) -o $@ $(LDBSEARCH_OBJ) $(DYNEXP) $(LDFLAGS) \
@@ -1797 +1797 @@
                 $(LIBTALLOC_LIBS) $(LIBTDB_LIBS)
 
-bin/ldbadd: $(BINARY_PREREQS) $(LDBADD_OBJ) @BUILD_POPT@ $(LIBTALLOC) $(LIBTDB) $(LIBWBCLIENT)
+bin/ldbadd: $(BINARY_PREREQS) $(LDBADD_OBJ) @BUILD_POPT@ $(LIBTALLOC) $(LIBTDB) $(LIBWBCLIENT)
         @echo Linking $@
         @$(CC) -o $@ $(LDBADD_OBJ) $(DYNEXP) $(LDFLAGS) \
@@ -1803 +1803 @@
                 $(LIBTALLOC_LIBS) $(LIBTDB_LIBS)
 
-bin/ldbmodify: $(BINARY_PREREQS) $(LDBMODIFY_OBJ) @BUILD_POPT@ $(LIBTALLOC) $(LIBTDB) $(LIBWBCLIENT)
+bin/ldbmodify: $(BINARY_PREREQS) $(LDBMODIFY_OBJ) @BUILD_POPT@ $(LIBTALLOC) $(LIBTDB) $(LIBWBCLIENT)
         @echo Linking $@
         @$(CC) -o $@ $(LDBMODIFY_OBJ) $(DYNEXP) $(LDFLAGS) \
@@ -1809 +1809 @@
                 $(LIBTALLOC_LIBS) $(LIBTDB_LIBS)
 
-bin/ldbdel: $(BINARY_PREREQS) $(LDBDEL_OBJ) @BUILD_POPT@ $(LIBTALLOC) $(LIBTDB) $(LIBWBCLIENT)
+bin/ldbdel: $(BINARY_PREREQS) $(LDBDEL_OBJ) @BUILD_POPT@ $(LIBTALLOC) $(LIBTDB) $(LIBWBCLIENT)
         @echo Linking $@
         @$(CC) -o $@ $(LDBDEL_OBJ) $(DYNEXP) $(LDFLAGS) \
@@ -1815 +1815 @@
                 $(LIBTALLOC_LIBS) $(LIBTDB_LIBS)
 
-bin/ldbrename: $(BINARY_PREREQS) $(LDBRENAME_OBJ) @BUILD_POPT@ $(LIBTALLOC) $(LIBTDB) $(LIBWBCLIENT)
+bin/ldbrename: $(BINARY_PREREQS) $(LDBRENAME_OBJ) @BUILD_POPT@ $(LIBTALLOC) $(LIBTDB) $(LIBWBCLIENT)
         @echo Linking $@
         @$(CC) $(FLAGS) -o $@ $(LDBRENAME_OBJ) $(DYNEXP) $(LDFLAGS) \
@@ -1821 +1821 @@
                 $(LIBTALLOC_LIBS) $(LIBTDB_LIBS)
 
-bin/versiontest: $(BINARY_PREREQS) lib/version_test.o $(VERSION_OBJ)
+bin/versiontest: $(BINARY_PREREQS) lib/version_test.o $(VERSION_OBJ)
         @echo Linking $@
         @$(CC) $(FLAGS) -o $@ $(VERSION_OBJ) lib/version_test.o

trunk/server/source3/dynconfig.c

@@ -41 +41 @@
  **/
 
+
 #define DEFINE_DYN_CONFIG_PARAM(name) \
 static char *dyn_##name; \
@@ -65 +66 @@
         return (dyn_##name == NULL);\
 }
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
 
 DEFINE_DYN_CONFIG_PARAM(SBINDIR)
@@ -83 +102 @@
 DEFINE_DYN_CONFIG_PARAM(SMB_PASSWD_FILE)
 DEFINE_DYN_CONFIG_PARAM(PRIVATE_DIR)
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+

trunk/server/source3/groupdb/mapping_ldb.c

@@ -81 +81 @@
         /* force the permissions on the ldb to 0600 - this will fix
            existing databases as well as new ones */
+
         if (chmod(db_path, 0600) != 0) {
                 goto failed;
         }
+
 
         if (!existed) {

trunk/server/source3/include/version.h

@@ -4 +4 @@
 #define SAMBA_VERSION_RELEASE 2
 #define SAMBA_VERSION_OFFICIAL_STRING "3.5.2"
+
+
+
 #ifdef SAMBA_VERSION_VENDOR_FUNCTION
 #  define SAMBA_VERSION_STRING SAMBA_VERSION_VENDOR_FUNCTION

trunk/server/source3/lib/charcnv.c

@@ -1804 +1804 @@
 */
 
+
 codepoint_t next_codepoint(const char *str, size_t *size)
 {

trunk/server/source3/lib/fault.c

@@ -54 +54 @@
         if (cont_fn) {
                 cont_fn(NULL);
+
 #ifdef SIGSEGV
                 CatchSignal(SIGSEGV,SIGNAL_CAST SIG_DFL);
@@ -62 +63 @@
 #ifdef SIGABRT
                 CatchSignal(SIGABRT,SIGNAL_CAST SIG_DFL);
+
 #endif
                 return; /* this should cause a core dump */
@@ -83 +85 @@
         cont_fn = fn;
 
+
 #ifdef SIGSEGV
         CatchSignal(SIGSEGV,SIGNAL_CAST sig_fault);
@@ -91 +94 @@
 #ifdef SIGABRT
         CatchSignal(SIGABRT,SIGNAL_CAST sig_fault);
+
 #endif
 }

trunk/server/source3/lib/iconv.c

@@ -128 +128 @@
 }
 
+
+
+
+
+
+
+
+
+
+
+
+
+
+
 #ifdef HAVE_NATIVE_ICONV
 /* if there was an error then reset the internal state,
@@ -136 +150 @@
                         char **outbuf, size_t *outbytesleft)
 {
+
+
+
+
+
         size_t ret = iconv((iconv_t)cd, 
                            (void *)inbuf, inbytesleft,
@@ -144 +163 @@
                 errno = saved_errno;
         }
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
         return ret;
 }
@@ -161 +201 @@
         char *bufp = cvtbuf;
         size_t bufsize;
+
+
+
 
         /* in many cases we can go direct */

trunk/server/source3/lib/ldb/common/ldb.c

@@ -117 +117 @@
         ldb_connect_fn fn;
 
+
         if (strchr(url, ':') != NULL) {
+
+
+
                 backend = talloc_strndup(ldb, url, strchr(url, ':')-url);
         } else {

trunk/server/source3/lib/ldb/ldb_tdb/ldb_tdb.c

@@ -1012 +1012 @@
 
         /* parse the url */
+
         if (strchr(url, ':')) {
+
+
+
                 if (strncmp(url, "tdb://", 6) != 0) {
                         ldb_debug(ldb, LDB_DEBUG_ERROR, "Invalid tdb URL '%s'", url);

trunk/server/source3/lib/pidfile.c

@@ -68 +68 @@
         }
 
+
         if (fcntl_lock(fd,SMB_F_SETLK,0,1,F_RDLCK)) {
                 /* we could get the lock - it can't be a Samba process */
                 goto noproc;
         }
+
 
         SAFE_FREE(pidFile);
@@ -95 +97 @@
         /* Add a suffix to the program name if this is a process with a
          * none default configuration file name. */
+
+
+
+
+
         if (strcmp( CONFIGFILE, get_dyn_CONFIGFILE()) == 0) {
                 name = SMB_STRDUP(program_name);
@@ -111 +118 @@
                 }
         }
+
+
+
 
         if (asprintf(&pidFile_name, "%s/%s.pid", lp_piddir(), name) == -1) {
@@ -144 +154 @@
                 exit(1);
         }
+
         /* Leave pid file open & locked for the duration... */
         SAFE_FREE(name);
+
+
+
 }
 

trunk/server/source3/lib/readline.c

@@ -102 +102 @@
                         return ret;
                 }
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
                 if (callback) {
                         callback();

trunk/server/source3/lib/select.c

@@ -63 +63 @@
 
         if (initialised != sys_getpid()) {
+
                 if (pipe(select_pipe) == -1)
+
+
+
                 {
                         DEBUG(0, ("sys_select: pipe failed (%s)\n",

trunk/server/source3/lib/smbrun.c

@@ -83 +83 @@
         }
 
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
         /* in this method we will exec /bin/sh with the correct
            arguments, after first setting stdout to point at the file */
@@ -202 +230 @@
         exit(83);
         return 1;
+
 }
 

trunk/server/source3/lib/system.c

@@ -641 +641 @@
 #if defined(HAVE_EXPLICIT_LARGEFILE_SUPPORT) && defined(HAVE_OFF64_T) && defined(HAVE_FTRUNCATE64)
         return ftruncate64(fd, offset);
+
+
 #else
         return ftruncate(fd, offset);
@@ -1571 +1573 @@
         }
         return ret;
+
+
 #else
         errno = ENOSYS;
@@ -1622 +1626 @@
         }
         return ret;
+
+
 #else
         errno = ENOSYS;
@@ -1675 +1681 @@
         }
         return ret;
+
+
 #else
         errno = ENOSYS;
@@ -1867 +1875 @@
         }
         return ret;
+
+
 #else
         errno = ENOSYS;
@@ -1896 +1906 @@
         }
         return ret;
+
+
 #else
         errno = ENOSYS;
@@ -1927 +1939 @@
         }
         return ret;
+
+
 #else
         errno = ENOSYS;
@@ -1966 +1980 @@
         }
         return ret;
+
+
 #else
         errno = ENOSYS;
@@ -2003 +2019 @@
         }
         return ret;
+
+
 #else
         errno = ENOSYS;
@@ -2042 +2060 @@
         }
         return ret;
+
+
 #else
         errno = ENOSYS;
@@ -2107 +2127 @@
         }
         return ret;
+
+
 #else
         errno = ENOSYS;
@@ -2171 +2193 @@
         }
         return ret;
+
+
 #else
         errno = ENOSYS;
@@ -2236 +2260 @@
         }
         return ret;
+
+
 #else
         errno = ENOSYS;

trunk/server/source3/lib/system_smbd.c

@@ -41 +41 @@
                                   int *grpcnt)
 {
+
         gid_t *gids_saved;
         int ret, ngrp_saved, num_gids;
@@ -112 +113 @@
         free(gids_saved);
         return ret;
+
+
+
+
 }
 #endif

trunk/server/source3/lib/util.c

@@ -2027 +2027 @@
 int set_maxfiles(int requested_max)
 {
-#if (defined(HAVE_GETRLIMIT) && defined(RLIMIT_NOFILE))
+#if (defined(HAVE_GETRLIMIT) && defined(RLIMIT_NOFILE))
         struct rlimit rlp;
         int saved_current_limit;

trunk/server/source3/lib/util_sec.c

@@ -93 +93 @@
 static void assert_uid(uid_t ruid, uid_t euid)
 {
+
         if ((euid != (uid_t)-1 && geteuid() != euid) ||
             (ruid != (uid_t)-1 && getuid() != ruid)) {
@@ -103 +104 @@
                 }
         }
+
 }
 
@@ -110 +112 @@
 static void assert_gid(gid_t rgid, gid_t egid)
 {
+
         if ((egid != (gid_t)-1 && getegid() != egid) ||
             (rgid != (gid_t)-1 && getgid() != rgid)) {
@@ -121 +124 @@
                 }
         }
+
 }
 

trunk/server/source3/lib/util_sock.c

@@ -1679 +1679 @@
         /* Create the socket directory or reuse the existing one */
 
+
         if (lstat(socket_dir, &st) == -1) {
                 if (errno == ENOENT) {
@@ -1707 +1708 @@
                 }
         }
+
 
         /* Create the socket file */
@@ -1718 +1720 @@
         }
 
+
+
+
         if (asprintf(&path, "%s/%s", socket_dir, socket_name) == -1) {
+
                 goto out_close;
         }

trunk/server/source3/lib/util_str.c

@@ -2264 +2264 @@
 *******************************************************************/
 
+
+
+
 #define INCLUDE_LIST "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz_/ \t.,"
+
 #define INSIDE_DQUOTE_LIST "$`\n\"\\"
 

trunk/server/source3/libaddns/dns.h

@@ -41 +41 @@
 #include <fcntl.h>
 #include <time.h>
+
 #include <string.h>
+
 #include <errno.h>
 #include <netdb.h>

trunk/server/source3/libaddns/dnserr.h

@@ -36 +36 @@
 /* Setup the DNS_ERROR typedef.  Technique takes from nt_status.h */
 
-#if defined(HAVE_IMMEDIATE_STRUCTURES)
+#if defined(HAVE_IMMEDIATE_STRUCTURES)
 typedef struct {uint32 v;} DNS_ERROR;
 #define ERROR_DNS(x) ((DNS_ERROR) { x })

trunk/server/source3/libsmb/clientgen.c

@@ -567 +567 @@
         bool mandatory_signing = false;
 
+
         /* Check the effective uid - make sure we are not setuid */
         if (is_setuid_root()) {
@@ -572 +573 @@
                 return NULL;
         }
+
 
         cli = TALLOC_ZERO_P(NULL, struct cli_state);

trunk/server/source3/libsmb/clifile.c

@@ -4360 +4360 @@
                         &setup, 1, 0,   /* setup, length, max */
                         param, param_len, 10, /* param, length, max */
+
+
+
                         NULL, data_len, cli->max_xmit /* data, length, max */
+
                                 )) {
                 return False;
@@ -4502 +4506 @@
         memset(param, 0, 6);
         SSVAL(param,0,fnum);
+
         SSVAL(param,2,SMB_INFO_SET_EA);
+
+
+
 
         return cli_get_ea_list(cli, setup, param, 6, ctx, pnum_eas, pea_list);

trunk/server/source3/locking/posix.c

@@ -252 +252 @@
         ret = SMB_VFS_GETLOCK(fsp, poffset, pcount, ptype, &pid);
 
+
         if (!ret && ((errno == EFBIG) || (errno == ENOLCK) || (errno ==  EINVAL))) {
 
@@ -277 +278 @@
                 }
         }
+
 
         DEBUG(8,("posix_fcntl_getlock: Lock query call %s\n", ret ? "successful" : "failed"));

trunk/server/source3/nmbd/asyncdns.c

@@ -141 +141 @@
         CatchChild();
 
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
         if (pipe(fd1) || pipe(fd2)) {
                 DEBUG(0,("can't create asyncdns pipes\n"));
                 return;
         }
+
 
         child_pid = sys_fork();

trunk/server/source3/nmbd/nmbd.c

@@ -30 +30 @@
 extern bool global_in_nmbd;
 
+
+
+
+
 extern bool override_logfile;
 
@@ -384 +388 @@
                 reload_nmbd_services( True );
         }
+
+
+
+
+
+
+
+
+
+
+
+
 
         return(ret);
@@ -776 +792 @@
         TALLOC_CTX *frame = talloc_stackframe(); /* Setup tos. */
 
+
+
+
+
         load_case_tables();
 

trunk/server/source3/nmbd/nmbd_serverlistdb.c

@@ -331 +331 @@
                 return;
         }
+
         fnamenew = talloc_asprintf(ctx, "%s.",
+
+
+
                                 fname);
         if (!fnamenew) {
@@ -418 +422 @@
 
         x_fclose(fp);
+
+
+
         unlink(fname);
         chmod(fnamenew,0644);

trunk/server/source3/nmbd/nmbd_winsserver.c

@@ -2389 +2389 @@
 
         x_fclose(fp);
+
+
+
         chmod(fnamenew,0644);
         unlink(fname);

trunk/server/source3/param/loadparm.c

@@ -4665 +4665 @@
                 case PRINT_AIX:
                 case PRINT_LPRNT:
+
                 case PRINT_LPROS2:
+
                         string_set(&pService->szLpqcommand, "lpq -P'%p'");
                         string_set(&pService->szLprmcommand, "lprm -P'%p' %j");
                         string_set(&pService->szPrintcommand, "lpr -r -P'%p' %s");
                         break;
+
+
+
+
+
+
+
 
                 case PRINT_LPRNG:
@@ -4938 +4947 @@
         string_set(&Globals.szGuestaccount, GUEST_ACCOUNT);
 
+
+
+
+
+
+
+
+
+
+
+
+
         /* using UTF8 by default allows us to support all chars */
         string_set(&Globals.unix_charset, DEFAULT_UNIX_CHARSET);
+
+
+
+
+
 
 #if defined(HAVE_NL_LANGINFO) && defined(CODESET)
         /* If the system supports nl_langinfo(), try to grab the value
            from the user's locale */
+
         string_set(&Globals.display_charset, "LOCALE");
+
+
+
+
+
+
 #else
         string_set(&Globals.display_charset, DEFAULT_DISPLAY_CHARSET);
 #endif
 
+
         /* Use codepage 850 as a default for the dos character set */
         string_set(&Globals.dos_charset, DEFAULT_DOS_CHARSET);
+
+
+
+
+
 
         /*

trunk/server/source3/passdb/pdb_smbpasswd.c

@@ -277 +277 @@
                          */
 
+
                         if (sys_stat(pfile, &sbuf1, false) != 0) {
                                 DEBUG(0, ("startsmbfilepwent_internal: unable to stat file %s. \
@@ -294 +295 @@
 
                         if( sbuf1.st_ex_ino == sbuf2.st_ex_ino) {
+
                                 /* No race. */
+
+
                                 break;
                         }
@@ -315 +319 @@
         setvbuf(fp, (char *)NULL, _IOFBF, 1024);
 
+
         /* Make sure it is only rw by the owner */
 #ifdef HAVE_FCHMOD
@@ -327 +332 @@
                 return NULL;
         }
+
 
         /* We have a lock on the file. */
@@ -1168 +1174 @@
          * Do an atomic rename - then release the locks.
          */
+
+
+
+
 
         if(rename(pfile2,pfile) != 0) {
@@ -1173 +1183 @@
         }
 
+
         endsmbfilepwent(fp, &smbpasswd_state->pw_file_lock_depth);
         endsmbfilepwent(fp_write,&pfile2_lockdepth);
+
         return True;
 }

trunk/server/source3/printing/printing.c

@@ -1431 +1431 @@
         DEBUG(3,("start_background_queue: Starting background LPQ thread\n"));
 
+
         if (pipe(pause_pipe) == -1) {
+
+
+
                 DEBUG(5,("start_background_queue: cannot create pipe. %s\n", strerror(errno) ));
                 exit(1);

trunk/server/source3/rpc_server/srv_srvsvc_nt.c

@@ -179 +179 @@
 
         if ( strcmp( fname, "." ) == 0 ) {
+
                 fullpath = talloc_asprintf(fenum->ctx, "C:%s", sharepath );
+
+
+
+
         } else {
+
                 fullpath = talloc_asprintf(fenum->ctx, "C:%s/%s",
                                 sharepath, fname );
+
+
+
+
         }
         if (!fullpath) {
@@ -294 +304 @@
                         "", remark);
         }
+
+
+
+
+
+
         path = talloc_asprintf(p->mem_ctx,
                         "C:%s", lp_pathname(snum));
@@ -386 +402 @@
                         "", remark);
         }
+
+
+
+
+
         path = talloc_asprintf(ctx, "C:%s", lp_pathname(snum));
         if (path) {
@@ -1489 +1510 @@
         }
 
+
+
+
+
+
         /* NT is braindead - it wants a C: prefix to a pathname ! So strip it. */
         if (strlen(ptr) > 2 && ptr[1] == ':' && ptr[0] != '/')
@@ -1496 +1522 @@
         if (*ptr != '/')
                 return NULL;
+
 
         return ptr;
@@ -2338 +2365 @@
 ***********************************************************************************/
 
+
 static const char *server_disks[] = {"C:"};
+
+
+
+
 
 static uint32 get_server_disk_count(void)

trunk/server/source3/smbd/dosmode.c

@@ -180 +180 @@
         if (ro_opts == MAP_READONLY_YES) {
                 /* Original Samba method - map inverse of user "w" bit. */
+
                 if ((smb_fname->st.st_ex_mode & S_IWUSR) == 0) {
+
+
+
                         result |= aRONLY;
                 }
@@ -190 +194 @@
         } /* Else never set the readonly bit. */
 
+
         if (MAP_ARCHIVE(conn) && ((smb_fname->st.st_ex_mode & S_IXUSR) != 0))
+
+
+
                 result |= aARCH;
 
+
         if (MAP_SYSTEM(conn) && ((smb_fname->st.st_ex_mode & S_IXGRP) != 0))
+
+
+
                 result |= aSYSTEM;
 
+
         if (MAP_HIDDEN(conn) && ((smb_fname->st.st_ex_mode & S_IXOTH) != 0))
+
+
+
                 result |= aHIDDEN;   
 
@@ -249 +265 @@
 #else
                                 ) {
+
+
+
+
 #endif
                         DEBUG(1,("get_ea_dos_attributes: Cannot get attribute "

trunk/server/source3/smbd/password.c

@@ -219 +219 @@
                 return -1;
         }
+
+
+
+
+
+
+
+
+
 
         DEBUG(3, ("Adding homes service for user '%s' using home directory: "

trunk/server/source3/smbd/reply.c

@@ -5652 +5652 @@
         bool dst_exists, old_is_stream, new_is_stream;
 
+
+
+
+
+
+
+
         status = check_name(conn, smb_fname_dst_in->base_name);
         if (!NT_STATUS_IS_OK(status)) {
@@ -5789 +5796 @@
         dst_exists = SMB_VFS_STAT(conn, smb_fname_dst) == 0;
 
-        if(!replace_if_exists && dst_exists) {
+        if(!replace_if_exists && dst_exists) {
                 DEBUG(3, ("rename_internals_fsp: dest exists doing rename "
                           "%s -> %s\n", smb_fname_str_dbg(fsp->fsp_name),

trunk/server/source3/smbd/server.c

@@ -1117 +1117 @@
         reopen_logs();
 
+
+
+
+
+
+
+
+
+
+
+
         DEBUG(0,("smbd version %s started.\n", samba_version_string()));
         DEBUGADD(0,("%s\n", COPYRIGHT_STARTUP_MESSAGE));

trunk/server/source3/smbd/service.c

@@ -68 +68 @@
         d = destname;
 
+
         *d++ = '/'; /* Always start with root. */
 
@@ -159 +160 @@
                 *(d-1) = '\0';
         }
+
+
+
+
 
         DEBUG(10,("set_conn_connectpath: service %s, connectpath = %s\n",

trunk/server/source3/smbd/sesssetup.c

@@ -75 +75 @@
         result = 0;
 
+
         tmp = message_push_string(outbuf, "Unix", STR_TERMINATE);
+
+
+
 
         if (tmp == -1) return -1;

trunk/server/source3/smbd/trans2.c

@@ -128 +128 @@
 
         pea->flags = 0;
+
         if (strnequal(ea_name, "user.", 5)) {
                 pea->name = talloc_strdup(mem_ctx, &ea_name[5]);
         } else {
+
+
+
                 pea->name = talloc_strdup(mem_ctx, ea_name);
         }
@@ -287 +291 @@
                 fstring dos_ea_name;
 
+
                 if (strnequal(names[i], "system.", 7)
                     || samba_private_attr_name(names[i]))
+
+
+
                         continue;
 
@@ -492 +500 @@
                 fstring unix_ea_name;
 
+
+
+
+
                 fstrcpy(unix_ea_name, "user."); /* All EA's must start with user. */
                 fstrcat(unix_ea_name, ea_list->ea.name);
+
 
                 canonicalize_ea_name(conn, fsp, fname, unix_ea_name);
@@ -5454 +5467 @@
         }
 
+
+
+
+
+
+
+
         DEBUG(10,("smb_set_file_time: setting utimes to modified values.\n"));
 
@@ -5463 +5483 @@
                 return map_nt_error_from_unix(errno);
         }
+
+
+
 
         notify_fname(conn, NOTIFY_ACTION_MODIFIED, action,

trunk/server/source3/smbd/vfs.c

@@ -716 +716 @@
                 return(0);
 
+
+
+
         if (*path == '/' && strcsequal(LastDir,path))
+
                 return(0);
 
@@ -938 +942 @@
                   resolved_name));
 
+
+
+
         if (*resolved_name != '/') {
+
                 DEBUG(0,("check_reduced_name: realpath doesn't return "
                          "absolute paths !\n"));

trunk/server/source3/torture/torture.c

@@ -5026 +5026 @@
         printf("num_eas = %d\n", (int)num_eas);
 
+
+
+
         if (num_eas != 20) {
+
                 printf("Should be 20 EA's stored... failing.\n");
                 correct = False;
@@ -5040 +5044 @@
         printf("Now deleting all EA's - case indepenent....\n");
 
-#if 1
+#if 
         cli_set_ea_path(cli, fname, "", "", 0);
 #else

trunk/server/source3/utils/net_usershare.c

@@ -946 +946 @@
 
         /* Attempt to replace any existing share by this name. */
+
+
+
         if (rename(full_path_tmp, full_path) != 0) {
                 unlink(full_path_tmp);
@@ -957 +960 @@
         }
 
+
         close(tmpfd);
+
 
         if (c->opt_long_list_entries) {

trunk/server/source3/utils/net_util.c

@@ -100 +100 @@
         int flags = 0;
 
+
+
+
+
+
+
+
         c->opt_password = net_prompt_pass(c, c->opt_user_name);
 

trunk/server/source3/web/cgi.c

@@ -315 +315 @@
         }
 
+
         pwd = getpwnam_alloc(talloc_autofree_context(), user);
         if (!pwd) {
@@ -329 +330 @@
         }
         TALLOC_FREE(pwd);
+
 }
 

trunk/server/source3/web/startstop.c

@@ -19 +19 @@
 
 #include "includes.h"
+
+
+
+
+
+
+
+
+
+
+
 #include "web/swat_proto.h"
 #include "dynconfig.h"
@@ -32 +43 @@
         }
 
+
+
+
+
+
         if (fork()) {
                 return;
@@ -41 +57 @@
         }
         exit(0);
+
 }
 
@@ -52 +69 @@
         }
 
+
+
+
+
+
         if (fork()) {
                 return;
@@ -61 +83 @@
         }
         exit(0);
+
 }
 
@@ -72 +95 @@
         }
 
+
+
+
+
+
         if (fork()) {
                 return;
@@ -81 +109 @@
         }
         exit(0);
+
 }
 
@@ -91 +120 @@
         if (geteuid() != 0) return;
 
+
+
+
+
+
+
         if (pid <= 0) return;
 
         kill(pid, SIGTERM);
+
 }
 
@@ -103 +139 @@
         if (geteuid() != 0) return;
 
+
+
+
+
+
+
         if (pid <= 0) return;
 
         kill(pid, SIGTERM);
+
 }
 #ifdef WITH_WINBIND
@@ -115 +158 @@
         if (geteuid() != 0) return;
 
+
+
+
+
+
+
         if (pid <= 0) return;
 
         kill(pid, SIGTERM);
+
 }
 #endif

trunk/server/source3/web/swat.c

@@ -1437 +1437 @@
         load_printers();
 
+
         cgi_setup(get_dyn_SWATDIR(), !demo_mode);
+
+
+
+
+
+
+
+
+
+
+
 
         print_header();