| 1 | ##
|
|---|
| 2 | ## Coding conventions in the Samba 3.0 tree
|
|---|
| 3 | ##
|
|---|
| 4 |
|
|---|
| 5 | ===========
|
|---|
| 6 | Quick Start
|
|---|
| 7 | ===========
|
|---|
| 8 |
|
|---|
| 9 | Coding style guidelines are about reducing the number of unnecessary
|
|---|
| 10 | reformatting patches and making things easier developers to work together.
|
|---|
| 11 | You don't have to like them or even agree with them, but once put in place
|
|---|
| 12 | we all have to abide by them (or vote to change them). However, coding
|
|---|
| 13 | style should never outweigh coding itself and so the the guidelines
|
|---|
| 14 | described here are hopefully easier enough to follow as they are very
|
|---|
| 15 | common and supported by tools and editors.
|
|---|
| 16 |
|
|---|
| 17 | The basic style, also mentioned in the SAMBA_4_0/prog_guide.txt is the
|
|---|
| 18 | Linux kernel coding style (See Documentation/CodingStyle in the kernel
|
|---|
| 19 | source tree). The closely matches what most Samba developers use already
|
|---|
| 20 | anyways.
|
|---|
| 21 |
|
|---|
| 22 | But to save you the trouble of reading the Linux kernel style guide, here
|
|---|
| 23 | are the highlights.
|
|---|
| 24 |
|
|---|
| 25 |
|
|---|
| 26 | * Maximum Line Width is 80 Characters
|
|---|
| 27 | The reason is not for people with low-res screens but rather sticking
|
|---|
| 28 | to 80 columns prevents you from easily nesting more than one level of
|
|---|
| 29 | if statements or other code blocks. Use source/script/count_80_col.pl
|
|---|
| 30 | to check your changes.
|
|---|
| 31 |
|
|---|
| 32 | * Use 8 Space Tabs to Indent
|
|---|
| 33 | No whitespace filler.
|
|---|
| 34 |
|
|---|
| 35 | * No Trailing Whitespace
|
|---|
| 36 | Use source/script/strip_trail_ws.pl to clean you files before committing.
|
|---|
| 37 |
|
|---|
| 38 | * Follow the K&R guidelines. We won't go throw them all here. You have
|
|---|
| 39 | a copy of "The C Programming Language" anyways right? You can also use
|
|---|
| 40 | the format_indent.sh script found in source/script/ if all else fails.
|
|---|
| 41 |
|
|---|
| 42 |
|
|---|
| 43 |
|
|---|
| 44 | ============
|
|---|
| 45 | Editor Hints
|
|---|
| 46 | ============
|
|---|
| 47 |
|
|---|
| 48 | Emacs
|
|---|
| 49 | -----
|
|---|
| 50 | Add the follow to your $HOME/.emacs file:
|
|---|
| 51 |
|
|---|
| 52 | (add-hook 'c-mode-hook
|
|---|
| 53 | (lambda ()
|
|---|
| 54 | (c-set-style "linux")
|
|---|
| 55 | (c-toggle-auto-state)))
|
|---|
| 56 |
|
|---|
| 57 |
|
|---|
| 58 | Vi
|
|---|
| 59 | --
|
|---|
| 60 | (Thanks to SATOH Fumiyasu <[email protected]> for these hints):
|
|---|
| 61 |
|
|---|
| 62 | For the basic vi editor including with all variants of *nix, add the
|
|---|
| 63 | following to $HOME/.exrc:
|
|---|
| 64 |
|
|---|
| 65 | set tabstop=8
|
|---|
| 66 | set shiftwidth=8
|
|---|
| 67 |
|
|---|
| 68 | For Vim, the following settings in $HOME/.vimrc will also deal with
|
|---|
| 69 | displaying trailing whitespace:
|
|---|
| 70 |
|
|---|
| 71 | if has("syntax") && (&t_Co > 2 || has("gui_running"))
|
|---|
| 72 | syntax on
|
|---|
| 73 | function! ActivateInvisibleCharIndicator()
|
|---|
| 74 | syntax match TrailingSpace "[ \t]\+$" display containedin=ALL
|
|---|
| 75 | highlight TrailingSpace ctermbg=Red
|
|---|
| 76 | endf
|
|---|
| 77 | autocmd BufNewFile,BufRead * call ActivateInvisibleCharIndicator()
|
|---|
| 78 | endif
|
|---|
| 79 | " Show tabs, trailing whitespace, and continued lines visually
|
|---|
| 80 | set list listchars=tab:»·,trail:·,extends:âŠ
|
|---|
| 81 |
|
|---|
| 82 | " highlight overly long lines same as TODOs.
|
|---|
| 83 | set textwidth=80
|
|---|
| 84 | autocmd BufNewFile,BufRead *.c,*.h exec 'match Todo /\%>' . &textwidth . 'v.\+/'
|
|---|
| 85 |
|
|---|
| 86 |
|
|---|
| 87 | =========================
|
|---|
| 88 | FAQ & Statement Reference
|
|---|
| 89 | =========================
|
|---|
| 90 |
|
|---|
| 91 | Comments
|
|---|
| 92 | --------
|
|---|
| 93 |
|
|---|
| 94 | Comments should always use the standard C syntax. I.e. /* ... */. C++
|
|---|
| 95 | style comments are not currently allowed.
|
|---|
| 96 |
|
|---|
| 97 |
|
|---|
| 98 | Indention & Whitespace & 80 columns
|
|---|
| 99 | -----------------------------------
|
|---|
| 100 |
|
|---|
| 101 | To avoid confusion, indentations are to be 8 character with tab (not
|
|---|
| 102 | 8 ' ' characters. When wrapping parameters for function calls,
|
|---|
| 103 | alignment parameter list with the first parameter on the previous line.
|
|---|
| 104 | Use tabs to get as close as possible and then fill in the final 7
|
|---|
| 105 | characters or less with whitespace. For example,
|
|---|
| 106 |
|
|---|
| 107 | var1 = foo(arg1, arg2,
|
|---|
| 108 | arg3);
|
|---|
| 109 |
|
|---|
| 110 | The previous example is intended to illustrate alignment of function
|
|---|
| 111 | parameters across lines and not as encourage for gratuitous line
|
|---|
| 112 | splitting. Never split a line before columns 70 - 79 unless you
|
|---|
| 113 | have a really good reason. Be smart about formatting.
|
|---|
| 114 |
|
|---|
| 115 |
|
|---|
| 116 | If, switch, & Code blocks
|
|---|
| 117 | -------------------------
|
|---|
| 118 |
|
|---|
|
|---|