Changeset 670

Timestamp:

Mar 10, 2010, 11:06:48 PM (15 years ago)

Author:

Dmitry A. Kuminov

Message:

qmake: os2/gnumake: Be consistent and use q function for space escaping everywhere in target and dependency lists.

Location:

trunk/qmake/generators/os2

Files:

• gnumake.cpp (modified) (7 diffs)
• gnumake.h (modified) (1 diff)

trunk/qmake/generators/os2/gnumake.cpp

@@ -90 +90 @@
     // dependency escaping is always done Unix-way since this is a requirement
     // of GNU make which allows " and ' to be part of the file name.
-    // Note that if the string is a make variable reference, we don't eascape!
+    // Note that if the string is a make variable reference, we don't eascape
+    // but instead use the q function defined in writeMakefile() that will do
+    // it at runtime.
     QString ret = path;
     QString trimmed = path.trimmed();
@@ -96 +98 @@
         ret.remove('\"');
         ret.replace(' ', "\\ ");
+
+
     }
     return ret;
@@ -522 +526 @@
 {
     t << "first: all" << endl;
-    t << "all: " << escapeDependencyPath(fileFixify(Option::output.fileName())) << " " << valGlue(escapeDependencyPaths(project->values("ALL_DEPS"))," "," "," ") << escapeFileVars(" $(DESTDIR_TARGET)") << endl << endl;
-    t << escapeFileVars("$(DESTDIR_TARGET): ") << var("PRE_TARGETDEPS") << " $(OBJECTS) " << var("POST_TARGETDEPS");
+    t << "all: " << escapeDependencyPath(fileFixify(Option::output.fileName())) << " "
+                 << valGlue(escapeDependencyPaths(project->values("ALL_DEPS"))," "," "," ")
+                 << escapeFileVars(" $(DESTDIR_TARGET)") << endl << endl;
+    t << escapeFileVars("$(DESTDIR_TARGET): ") << escapeFileVars(var("PRE_TARGETDEPS"))
+                                               << escapeFileVars(" $(OBJECTS) ")
+                                               << escapeFileVars(var("POST_TARGETDEPS"));
     if (!project->isEmpty("QMAKE_PRE_LINK"))
         t << "\n\t" <<var("QMAKE_PRE_LINK");
@@ -564 +572 @@
             if (!project->isEmpty("DEF_FILE_TEMPLATE")) {
                 t << "DEF_FILE_TEMPLATE = " << escapeFilePath(var("DEF_FILE_TEMPLATE")) << endl;
-                project->values("QMAKE_GENDEF_DEPS") += escapeFileVars("$(DEF_FILE_TEMPLATE)");
+                project->values("QMAKE_GENDEF_DEPS") += ;
             }
             if (!project->isEmpty("DEF_FILE_MAP")) {
                 t << "DEF_FILE_MAP  = " << escapeFilePath(var("DEF_FILE_MAP")) << endl;
-                project->values("QMAKE_GENDEF_DEPS") += escapeFileVars("$(DEF_FILE_MAP)");
+                project->values("QMAKE_GENDEF_DEPS") += ;
             }
         }
@@ -578 +586 @@
         }
         t << "DEF_FILE      = " << escapeFilePath(var("DEF_FILE")) << endl;
-        project->values("POST_TARGETDEPS") += escapeFileVars("$(DEF_FILE)");
+        project->values("POST_TARGETDEPS") += ;
     }
 
@@ -598 +606 @@
         if (project->isEmpty("DEF_FILE")) {
             /* generate a DEF file for the DLL when not supplied */
-            t << escapeFileVars("$(DEF_FILE): ") << var("QMAKE_GENDEF_DEPS");
+            t << escapeFileVars("$(DEF_FILE): ") << );
             t << valGlue(var("QMAKE_RUN_GENDEF").split(";;"), "\n\t", "\n\t", "") << endl;
         }
@@ -755 +763 @@
 }
 
+
 QString GNUMakefileGenerator::escapeFileVars(const QString &vars)
 {
     /* In DOS environment, we escape spaces and other illegal characters in
-     * filenames with double quotes. However, this is not appropriate for make
-     * rule definitions (targets/dependencies) where Unix escaping is
+     * filenames with double quotes. However, this is not appropriate for 
+     * rule definitions (targets/dependencies) where Unix escaping is
      * expected. If we'd deal only with immediate strings, we could provide
      * necessary escaping in place, but we often use make variables instead of
      * direct file names so we must perform such escaping on the fly. This is
      * what we do here using the q function that we define in writeMakefile().*/
-    if (isDosLikeShell()) {
-        QString ret = vars;
-        QRegExp rx = QRegExp("\\$\\((.+)\\)");
-        rx.setMinimal(true);
-        ret.replace(rx, "$(call q,$(\\1))");
-        return ret;
-    }
-    return vars;
+    QString ret = vars;
+    QRegExp rx = QRegExp("(?:\\$\\(call q,\\$\\((.+)\\)\\))|"
+                         "(?:\\$\\(([^$)]+)\\))");
+    rx.setMinimal(true);
+    ret.replace(rx, "$(call q,$(\\1\\2))");
+    return ret;
 }
 

trunk/qmake/generators/os2/gnumake.h

@@ -89 +89 @@
     void createLinkerResponseFiles(QTextStream &t);
     void createCompilerResponseFiles(QTextStream &t);
-    QString escapeFileVars(const QString &base);
+
+    static QString escapeFileVars(const QString &base);
 
     bool init_flag;