Changeset 362 for trunk/qmake/generators

Timestamp:

Nov 30, 2009, 12:56:45 AM (16 years ago)

Author:

Dmitry A. Kuminov

Message:

qmake: Don't assume that relative paths in all OSes look like in *nix [vendor bug].

Location:

trunk/qmake/generators

Files:

• makefile.cpp (modified) (9 diffs)
• makefiledeps.cpp (modified) (2 diffs)
• metamakefile.cpp (modified) (1 diff)
• win32/winmakefile.cpp (modified) (1 diff)

trunk/qmake/generators/makefile.cpp

@@ -125 +125 @@
     }
     bool ret = true;
-#if defined(Q_OS_WIN) || defined(Q_OS_OS2)
+#if defined(Q_OS_WIN)
     bool driveExists = true;
     if(!QDir::isRelativePath(path)) {
@@ -138 +138 @@
     }
     if(driveExists)
+
+
+
+
+
+
+
 #endif
     {
@@ -341 +348 @@
                         vpath += Option::output_dir;
                 }
-                for(QStringList::Iterator vpath_it = vpath.begin();
-                    vpath_it != vpath.end(); ++vpath_it) {
-                    QString real_dir = Option::fixPathToLocalOS((*vpath_it));
-                    if(exists(real_dir + QDir::separator() + val)) {
-                        QString dir = (*vpath_it);
-                        if(dir.right(Option::dir_sep.length()) != Option::dir_sep)
-                            dir += Option::dir_sep;
-                        val = dir + val;
+                foreach(const QString &vp, vpath) {
+                    QString real_val = QDir(vp).absoluteFilePath(val);
+                    if (exists(real_val)) {
+                        val = real_val;
                         if(!(flags & VPATH_NoFixify))
                             val = fileFixify(val);
@@ -850 +853 @@
                     file = libinfo.first("QMAKE_PRL_TARGET");
                     if(QDir::isRelativePath(file))
-                        file.prepend(dir);
+                        file);
                 }
             }
@@ -2782 +2785 @@
     if(fix == FileFixifyAbsolute || (fix == FileFixifyDefault && project->isActiveConfig("no_fixpath"))) {
         if(fix == FileFixifyAbsolute && QDir::isRelativePath(ret)) //already absolute
-            ret.prepend(pwd);
+            ret);
         ret = Option::fixPathToTargetOS(ret, false, canon);
     } else { //fix it..
@@ -2800 +2803 @@
         if(out_dir != in_dir || !qfileinfo.isRelative()) {
             if(qfileinfo.isRelative()) {
-                ret = in_dir + "/" + qfile;
+                ret = ;
                 qfileinfo.setFile(ret);
             }
@@ -3022 +3025 @@
         if(!file.fileName().isEmpty()) {
             if(QDir::isRelativePath(file.fileName()))
-                file.setFileName(Option::output_dir + "/" + file.fileName()); //pwd when qmake was run
+                file.setFileName()); //pwd when qmake was run
             QFileInfo fi(fileInfo(file.fileName()));
             if(fi.isDir())
@@ -3035 +3038 @@
     }
     if(QDir::isRelativePath(file.fileName())) {
-        QString fname = Option::output_dir;  //pwd when qmake was run
-        if(!fname.endsWith("/"))
-            fname += "/";
-        fname += file.fileName();
-        file.setFileName(fname);
+        file.setFileName(QDir(Option::output_dir).absoluteFilePath(file.fileName())); //pwd when qmake was run
     }
     if(!build.isEmpty())
@@ -3057 +3056 @@
         od = Option::fixPathToTargetOS(od);
         if(QDir::isRelativePath(od))
-            od.prepend(Option::output_dir);
+            od);
         Option::output_dir = od;
         return true;

trunk/qmake/generators/makefiledeps.cpp

@@ -625 +625 @@
                     if(try_local) {
                         QString dir = findFileInfo(file->file).path();
-                        if(QDir::isRelativePath(dir))
-                            dir.prepend(qmake_getpwd() + "/");
-                        if(!dir.endsWith("/"))
-                            dir += "/";
-                        QMakeLocalFileName f(dir + lfn.local());
+                        QMakeLocalFileName f(QDir(dir).absoluteFilePath(lfn.local()));
                         if(findFileInfo(f).exists()) {
                             lfn = fixPathForFile(f);
@@ -636 +632 @@
                     }
                     if(!exists) { //path lookup
-                        for(QList<QMakeLocalFileName>::Iterator it = depdirs.begin(); it != depdirs.end(); ++it) {
-                            QMakeLocalFileName f((*it).real() + Option::dir_sep + lfn.real());
+                        for) {
+                            QMakeLocalFileName f());
                             QFileInfo fi(findFileInfo(f));
                             if(fi.exists() && !fi.isDir()) {

trunk/qmake/generators/metamakefile.cpp

@@ -325 +325 @@
             sub->input_dir = subdir.absolutePath();
             if(subdir.isRelative() && old_output_dir != oldpwd) {
-                sub->output_dir = old_output_dir + "/" + subdir.path();
+                sub->output_dir = );
                 printf("Reading %s [%s]\n", subdir.absoluteFilePath().toLatin1().constData(), sub->output_dir.toLatin1().constData());
             } else { //what about shadow builds?

trunk/qmake/generators/win32/winmakefile.cpp

@@ -246 +246 @@
                         tmp = opt;
                     for(QList<QMakeLocalFileName>::Iterator it = libdirs.begin(); it != libdirs.end(); ++it) {
-                        QString prl = (*it).local() + Option::dir_sep + tmp;
+                        QString prl = ;
                         // the original is used as the key
                         QString orgprl = prl;