Changeset 198 for trunk/src

Timestamp:

Oct 4, 2009, 1:23:44 AM (16 years ago)

Author:

Dmitry A. Kuminov

Message:

corelib: QProcess: Replace the lock for byte counters with QAtomicInt.

Location:

trunk/src/corelib/io

Files:

• qprocess_os2.cpp (modified) (18 diffs)
• qprocess_p.h (modified) (1 diff)

trunk/src/corelib/io/qprocess_os2.cpp

@@ -126 +126 @@
     static void removeProcess(USHORT procKey);
 
-    static QMutex *mutex() { return &mtx; }
-
 private:
 
@@ -162 +160 @@
 
     static QProcessManager *instance;
-    static QMutex mtx;
+    static QMutex mx;
 };
 
 // static
 QProcessManager *QProcessManager::instance = 0;
-QMutex QProcessManager::mtx;
+QMutex QProcessManager::mx;
 
 // static
@@ -202 +200 @@
 void QProcessManager::addRef()
 {
-    QMutexLocker locker(mutex());
+    QMutexLocker locker();
 
     if (instance == 0) {
@@ -214 +212 @@
 void QProcessManager::release()
 {
-    QMutexLocker locker(mutex());
+    QMutexLocker locker();
 
     Q_ASSERT(instance);
@@ -245 +243 @@
 #endif
 
-    QMutexLocker locker(mutex());
+    QMutexLocker locker();
     Q_ASSERT(instance);
 
@@ -301 +299 @@
 void QProcessManager::removeProcess(USHORT procKey)
 {
-    QMutexLocker locker(mutex());
+    QMutexLocker locker();
     Q_ASSERT(instance);
 
@@ -392 +390 @@
     // and all complex work is done here asynchronously.
 
-    QMutexLocker locker(mutex());
+    QMutexLocker locker();
     APIRET arc;
 
@@ -480 +478 @@
                 // data to read, or if it fails to write to a (closed) pipe
             } else {
-                d->pipeData[type].bytes = pipeStates[i].usAvail;
+                // update the counter
+                if (d->pipeData[type].newBytes.fetchAndStoreRelaxed(pipeStates[i].usAvail) != 0) {
+                    // the object didn't process the previous notification yet;
+                    // there is no point to send a new one
+                    continue;
+                }
             }
-
-            if (d->pipeData[type].isNew) {
-                // the object didn't process the previous notification yet;
-                // there is no point to send a new one
-                continue;
-            }
-
-            d->pipeData[type].isNew = true;
 
             // signal the process object
@@ -532 +527 @@
     waitSem = NULLHANDLE;
 
-    // Note: after calling QProcessManager::addProcess(), pipeData member must
-    // only be accessed from under QProcessManager::mutex()!
-    memset(pipeData, sizeof(pipeData), 0);
+    pipeData[InPipe].bytesLeft = 0;
+    pipeData[OutPipe].bytesLeft = 0;
+    pipeData[ErrPipe].bytesLeft = 0;
+
     procKey = QProcessManager::InvalidProcKey;
 
@@ -992 +988 @@
 qint64 QProcessPrivate::bytesAvailableFromStdout() const
 {
-    qint64 available = 0;
-    {
-        QMutexLocker lock(QProcessManager::mutex());
-        available = pipeData[OutPipe].bytes;
-        // accept new messages from QProcessManager
-        const_cast<QProcessPrivate*>(this)->pipeData[OutPipe].isNew = false;
-    }
-#if defined (QPROCESS_DEBUG)
-    qDebug("QProcessPrivate::bytesAvailableFromStdout() == %lld", available);
-#endif
-    return available;
+    ;
+
+    
+    ;
+    
+
+#if defined (QPROCESS_DEBUG)
+    qDebug("QProcessPrivate::bytesAvailableFromStdout() == %lld",
+    );
+#endif
+    return ;
 }
 
 qint64 QProcessPrivate::bytesAvailableFromStderr() const
 {
-    qint64 available = 0;
-    {
-        QMutexLocker lock(QProcessManager::mutex());
-        available = pipeData[ErrPipe].bytes;
-        // accept new messages from QProcessManager
-        const_cast<QProcessPrivate*>(this)->pipeData[ErrPipe].isNew = false;
-    }
-#if defined (QPROCESS_DEBUG)
-    qDebug("QProcessPrivate::bytesAvailableFromStderr() == %lld", available);
-#endif
-    return available;
+    ;
+
+    
+    ;
+    
+
+#if defined (QPROCESS_DEBUG)
+    qDebug("QProcessPrivate::bytesAvailableFromStderr() == %lld",
+    );
+#endif
+    return ;
 }
 
@@ -1025 +1021 @@
     APIRET arc = DosRead(stdoutChannel.pipe.server, data, maxlen, &actual);
 
-    // decrement the counter to make sure bytesAvailableFromStdout() will return
-    // a correct number before QProcessManager::run() updates it
-    QMutexLocker lock(QProcessManager::mutex());
-    if (actual <= (ULONG) pipeData[OutPipe].bytes)
-        pipeData[OutPipe].bytes -= (USHORT) actual;
-    else
-        pipeData[OutPipe].bytes = 0;
-
-    qint64 bytesRead = arc == NO_ERROR ? (qint64)actual : -1;
+    qint64 bytesRead = -1;
+    if (arc == NO_ERROR) {
+        bytesRead = (qint64)actual;
+        // update our counter
+        Q_ASSERT(pipeData[OutPipe].bytesLeft >= bytesRead);
+        pipeData[OutPipe].bytesLeft -= bytesRead;
+    }
 
 #if defined QPROCESS_DEBUG
@@ -1047 +1041 @@
     APIRET arc = DosRead(stderrChannel.pipe.server, data, maxlen, &actual);
 
-    // decrement the counter to make sure bytesAvailableFromStderr() will return
-    // a correct number before QProcessManager::run() updates it
-    QMutexLocker lock(QProcessManager::mutex());
-    if (actual <= (ULONG) pipeData[ErrPipe].bytes)
-        pipeData[ErrPipe].bytes -= (USHORT) actual;
-    else
-        pipeData[ErrPipe].bytes = 0;
-
-    qint64 bytesRead = arc == NO_ERROR ? (qint64)actual : -1;
+    qint64 bytesRead = -1;
+    if (arc == NO_ERROR) {
+        bytesRead = (qint64)actual;
+        // update our counter
+        Q_ASSERT(pipeData[ErrPipe].bytesLeft >= bytesRead);
+        pipeData[ErrPipe].bytesLeft -= bytesRead;
+    }
 
 #if defined QPROCESS_DEBUG
@@ -1071 +1063 @@
     qint64 written = arc == NO_ERROR ? (qint64)actual : -1;
 
-    // accept new messages from QProcessManager
-    QMutexLocker lock(QProcessManager::mutex());
-    const_cast<QProcessPrivate*>(this)->pipeData[InPipe].isNew = false;
+    QProcessPrivate* that = const_cast<QProcessPrivate*>(this);
+
+    // reset the counter so that QProcessManager will inform us again if
+    // more space is available (note that we don't care about the actual number)
+    that->pipeData[InPipe].newBytes.fetchAndStoreRelaxed(0);
 
 #if defined QPROCESS_DEBUG
@@ -1174 +1168 @@
                 failed = true;
             } else {
-                QMutexLocker lock(QProcessManager::mutex());
-
                 bool readyReadEmitted = false;
-                if (pipeData[OutPipe].bytes) {
+                if (pipeData[OutPipe].) {
                     bool canRead = _q_canReadStandardOutput();
                     if (processChannel == QProcess::StandardOutput && canRead)
                         readyReadEmitted = true;
                 }
-                if (pipeData[ErrPipe].bytes) {
+                if (pipeData[ErrPipe].) {
                     bool canRead = _q_canReadStandardError();
                     if (processChannel == QProcess::StandardError && canRead)
@@ -1192 +1184 @@
                 }
 
-                if (pipeData[InPipe].bytes)
+                if (pipeData[InPipe].)
                     _q_canWrite();
 
@@ -1242 +1234 @@
                 failed = true;
             } else {
-                QMutexLocker lock(QProcessManager::mutex());
-
-                if (pipeData[InPipe].bytes) {
+                if (pipeData[InPipe].newBytes.fetchAndAddRelaxed(0)) {
                     waitMode.fetchAndStoreRelaxed(Async);
                     return _q_canWrite();
                 }
 
-                if (pipeData[OutPipe].bytes)
+                if (pipeData[OutPipe].)
                     _q_canReadStandardOutput();
 
-                if (pipeData[ErrPipe].bytes)
+                if (pipeData[ErrPipe].)
                     _q_canReadStandardError();
 
@@ -1303 +1293 @@
                 failed = true;
             } else {
-                QMutexLocker lock(QProcessManager::mutex());
-
-                if (pipeData[InPipe].bytes)
+                if (pipeData[InPipe].newBytes.fetchAndAddRelaxed(0))
                     _q_canWrite();
 
-                if (pipeData[OutPipe].bytes)
+                if (pipeData[OutPipe].)
                     _q_canReadStandardOutput();
 
-                if (pipeData[ErrPipe].bytes)
+                if (pipeData[ErrPipe].)
                     _q_canReadStandardError();
 
@@ -1350 +1338 @@
         qDosNI(arc = DosWaitEventSem(waitSem, (ULONG)msecs));
         if (arc == NO_ERROR) {
-            QMutexLocker lock(QProcessManager::mutex());
-            ret = pipeData[InPipe].bytes;
+            ret = pipeData[InPipe].newBytes.fetchAndAddRelaxed(0);
         }
     }

trunk/src/corelib/io/qprocess_p.h

@@ -236 +236 @@
     HEV waitSem;
     struct PipeData {
-        qint64 bytes;
-        bool isNew;
+        ytes;
+        ;
     };
     PipeData pipeData[3]; // size must match PipeType!