From: Peter Zhu <peter@peterzhu.ca>
Date: Tue, 20 Aug 2024 15:23:01 +0000 (-0400)
Subject: Remove wmap_free_entry
X-Git-Tag: v3_4_0_preview2~826
X-Git-Url: https://repo.or.cz/ruby.git/commitdiff_plain/34bf724a9b53ce724a2cc02195221b32879b962c

Remove wmap_free_entry
---

diff --git a/weakmap.c b/weakmap.c
index 4830d0bbcd..fb2fd22875 100644
--- a/weakmap.c
+++ b/weakmap.c
@@ -40,16 +40,6 @@ wmap_live_p(VALUE obj)
     return !UNDEF_P(obj);
 }
 
-static void
-wmap_free_entry(VALUE *key, VALUE *val)
-{
-    RUBY_ASSERT(key + 1 == val);
-
-    /* We only need to free key because val is allocated beside key on in the
-     * same malloc call. */
-    ruby_sized_xfree(key, sizeof(struct weakmap_entry));
-}
-
 struct wmap_foreach_data {
     int (*func)(struct weakmap_entry *, st_data_t);
     st_data_t arg;
@@ -75,7 +65,7 @@ wmap_foreach_i(st_data_t key, st_data_t val, st_data_t arg)
         return ret;
     }
     else {
-        wmap_free_entry((VALUE *)key, (VALUE *)val);
+        ruby_sized_xfree(entry, sizeof(struct weakmap_entry));
 
         return ST_DELETE;
     }
@@ -113,7 +103,10 @@ wmap_mark(void *ptr)
 static int
 wmap_free_table_i(st_data_t key, st_data_t val, st_data_t arg)
 {
-    wmap_free_entry((VALUE *)key, (VALUE *)val);
+    struct weakmap_entry *entry = (struct weakmap_entry *)key;
+    RUBY_ASSERT(&entry->val == (VALUE *)val);
+    ruby_sized_xfree(entry, sizeof(struct weakmap_entry));
+
     return ST_CONTINUE;
 }
 
@@ -533,7 +526,8 @@ wmap_delete(VALUE self, VALUE key)
         rb_gc_remove_weak(self, (VALUE *)orig_key_data);
         rb_gc_remove_weak(self, (VALUE *)orig_val_data);
 
-        wmap_free_entry((VALUE *)orig_key_data, (VALUE *)orig_val_data);
+        struct weakmap_entry *entry = (struct weakmap_entry *)orig_key_data;
+        ruby_sized_xfree(entry, sizeof(struct weakmap_entry));
 
         if (wmap_live_p(orig_val)) {
             return orig_val;